Uh oh!
There was an error while loading. Please reload this page.
[v9.x backport] build: include the libuv and zlib into node - #18912
Closed
yhwang wants to merge 4 commits into
Closed
[v9.x backport] build: include the libuv and zlib into node#18912yhwang wants to merge 4 commits into
yhwang wants to merge 4 commits into
Conversation
addaleax
approved these changes
Feb 21, 2018
yhwang
commented
Feb 21, 2018
MemberAuthor
MylesBorinsforce-pushed
the
v9.x-staging
branch
from
February 21, 2018 23:13
b9b5810 to
6edf952Compareyhwang
commented
Feb 22, 2018
MemberAuthor
I saw some freebsd builds failed on test cases: is it a known issue or just flaky test case? |
rvagg
commented
Feb 22, 2018
Member
something's up with these branches, '96 commits' isn't right, perhaps rebase? |
PR-URL: nodejs#18270Fixes: nodejs#8307 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: nodejs#18749 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Add two regression tests for stdio over pipes. test-stdio-pipe-access tests if accessing stdio pipe that is being read by another process does not deadlocks Node.js. This was reported in nodejs#10836 and was fixed in v8.3.0. The deadlock would happen intermittently, so we run the test 5 times. test-stdio-pipe-redirect tests if redirecting one child process stdin to another process stdout does not crash Node as reported in nodejs#17493. It was fixed in nodejs#18019. PR-URL: nodejs#18614 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by: Yihong Wang <yh.wang@ibm.com> Fixes: nodejs#17444 PR-URL: nodejs#18383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
yhwangforce-pushed
the
backport-18383-to-v9.x-staging
branch
from
February 22, 2018 17:45
0879dec to
4aef7dfCompareyhwang
commented
Feb 22, 2018
MemberAuthor
rebased and new CI: https://ci.nodejs.org/job/node-test-commit/16446/ |
addaleax
commented
Feb 26, 2018
Member
@yhwang Thanks for the backport! This has a conflict now, but the original patch as it landed on master lands cleanly now, so I’ll be closing this. Sorry for the wasted time! |
yhwang
commented
Feb 26, 2018
MemberAuthor
@addaleax sure. If there is the need for backport again, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add libuv and zlib into node executable and shared lib. Also fix an
issue that openssl is not fully included in node executable for macOS.
Signed-off-by: Yihong Wang yh.wang@ibm.com
Fixes: #17444
PR-URL: #18383
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build