repl: better handling of recoverable errors

[princejwesley]

Better handling of recoverable errors in REPL module

Below syntax errors are handled without force .break/clear

• Unexpected Token (prefix errors)
• missing ) after argument list

In the multiline expression, recoverable errors are truly
recoverable, otherwise syntax error will be thrown.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

repl

[Leko]

LGTM

[Leko]

CI: https://ci.nodejs.org/job/node-test-pull-request/13359/

[Leko]

CI failed but I think those errors are not related to this PR.

not ok 712 parallel/test-http-pause
---
duration_ms: 0.213
severity: fail
stack: |-
...

https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian8-64/16655/console

not ok 2002 sequential/test-fs-readfile-tostring-fail
---
duration_ms: 8.50
severity: crashed
stack: |-
oh no!
exit code: CRASHED (Signal: 9)
...

https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64/16655/console

[Leko]

CI again: https://ci.nodejs.org/job/node-test-pull-request/13375/

[0joshuaolson1]

Is this the right place to add other syntax errors that the repl doesn't handle correctly? I can't find an issue for it.

[BridgeAR]

LGTM. Just a nit and a question.

[BridgeAR]

Nit: please remove the else. This is a style that is normally not used here.

[princejwesley]

rebasing and amending to same commit

[BridgeAR]

I guess recovering from e.g.

'`abc ${ test'

is not possible anymore?

[princejwesley]

Yes, only some forms are not possible. For instance, below one is possible.

`abc ${test}`

Its mostly consistent with chrome console behaviour except for couple of cases.

1. we handle 'missing ) after argument list' error better than chrome console.
2. we allow repl commands in multiline mode which should otherwise be treated as properties/functions.
   princejwesley@c1796b8 (wip)

> (function() {
... x = { help: () => 'help received' };
... return x
... .help (); <-- no repl command parsing in multiline mode
.break Sometimes you get stuck, this gets you out
.clear Alias for .break
.editor Enter editor mode
.exit Exit the repl
.help Print this help message
.load Load JS from a file into the REPL session
.save Save all evaluated commands in this REPL session to a file
...

(I'll give PR over the weekend)

[BridgeAR]

@0joshuaolson1 please open a new issue in case you think the repl should recover from errors that you ran into.

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/13543/

[BridgeAR]

Landed in ebfa8b1 🎉