Skip to content

src: remove node namespace qualifiers - #18962

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:remove-node-namespace-qualifier
Closed

src: remove node namespace qualifiers#18962
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:remove-node-namespace-qualifier

Conversation

@danbev

@danbevdanbev commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: remove node namespace qualifiers
9899c95
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 23, 2018
@danbev

danbev commented Feb 23, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/13350/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2018
@danbev

danbev commented Feb 26, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in cae4182.

@danbevdanbev closed this Feb 26, 2018
danbev added a commit that referenced this pull request Feb 26, 2018
@danbev
src: remove node namespace qualifiers
cae4182
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@danbev
danbev deleted the remove-node-namespace-qualifier branch February 26, 2018 06:26
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
@danbev@addaleax
src: remove node namespace qualifiers
89323da
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: nodejs#18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@danbev@addaleax
src: remove node namespace qualifiers
2282dce
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@addaleaxaddaleax mentioned this pull request Feb 27, 2018
Closed
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@danbev@MayaLekova
src: remove node namespace qualifiers
6258567
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: nodejs#18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 8, 2018
@danbev@MylesBorins
src: remove node namespace qualifiers
09151e0
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@danbev@MylesBorins
src: remove node namespace qualifiers
77c04c9
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@danbev@MylesBorins
src: remove node namespace qualifiers
69efa9f
This commit removes unneccessary node namespace qualifiers in node.cc
for consistency.
PR-URL: #18962
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@Fishrock123Fishrock123Fishrock123 approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danbev@addaleax@Fishrock123@TimothyGu@targos@cjihrig@MylesBorins@BridgeAR@nodejs-github-bot