Skip to content

module: fix cyclical dynamic import - #18965

Closed
bmeck wants to merge 1 commit into
nodejs:masterfrom
bmeck:fix-cyclic-dynamic-import
Closed

module: fix cyclical dynamic import#18965
bmeck wants to merge 1 commit into
nodejs:masterfrom
bmeck:fix-cyclic-dynamic-import

Conversation

@bmeck

@bmeckbmeck commented Feb 23, 2018•
edited
Loading

Copy link
Copy Markdown
Member

ensures that instantiation result is only used during initial loading. current loading mechanism would use the empty promise sentinel if the import() fired in a cyclic manner.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

module

@bmeck
bmeck requested review from devsnek and hybristFebruary 23, 2018 21:14
@bmeck
bmeckforce-pushed the fix-cyclic-dynamic-import branch from b6a542f to a3f7f9aCompareFebruary 23, 2018 21:26
@mscdex

mscdex commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

Typo in commit message

@bmeck
bmeckforce-pushed the fix-cyclic-dynamic-import branch from 483e758 to 881ae75CompareFebruary 23, 2018 21:41
@bmeck
module: fix cyclical dynamic import
881ae75
ensures that instantiation result is only used during initial loading
@mscdexmscdex changed the title module: fix cylcical dynamic importmodule: fix cyclical dynamic importFeb 23, 2018
Fishrock123
Fishrock123 approved these changes Feb 24, 2018
View reviewed changes

@Fishrock123Fishrock123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/13354/

@TimothyGuTimothyGu added the esm Issues and PRs related to the ECMAScript Modules implementation. label Feb 27, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2018
@bmeck

bmeck commented Mar 5, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 023f49c

bmeck added a commit that referenced this pull request Mar 5, 2018
@bmeck
module: fix cyclical dynamic import
023f49c
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@bmeck@MylesBorins
module: fix cyclical dynamic import
3c8f4a2
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Mar 6, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@bmeck@MylesBorins
module: fix cyclical dynamic import
5583547
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@bmeck@MylesBorins
module: fix cyclical dynamic import
bc1038a
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@bmeck@MylesBorins
module: fix cyclical dynamic import
a3b9542
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Mar 7, 2018
@bmeck@MylesBorins
module: fix cyclical dynamic import
95f6467
ensures that instantiation result is only used during initial loading
PR-URL: #18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@bmeck@MayaLekova
module: fix cyclical dynamic import
78b6eb9
ensures that instantiation result is only used during initial loading
PR-URL: nodejs#18965
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell

jasnell commented Aug 17, 2018

Copy link
Copy Markdown
Member

Should this be backported to 8.x?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@hybristhybristhybrist approved these changes
@guybedfordguybedfordguybedford approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+2 more reviewers
@Fishrock123Fishrock123Fishrock123 approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@bmeck@mscdex@jasnell@hybrist@guybedford@Fishrock123@cjihrig@devsnek@BridgeAR@TimothyGu@joyeecheung