Skip to content

http2: refer to stream errors by name - #18966

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:http2-error-code-name
Closed

http2: refer to stream errors by name#18966
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:http2-error-code-name

Conversation

@addaleax

@addaleaxaddaleax commented Feb 23, 2018

Copy link
Copy Markdown
Member

Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs/http2

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 23, 2018
@joyeecheung

joyeecheung commented Feb 24, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13360/

@joyeecheung

joyeecheung commented Feb 24, 2018

Copy link
Copy Markdown
Member

There is a test missing the update

 not ok 2039 sequential/test-http2-max-session-memory
---
duration_ms: 0.269
severity: fail
stack: |-
(node:12676) ExperimentalWarning: The http2 module is an experimental API.
assert.js:74
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: 'Stream closed with error code NGHTTP2_ENHANCE_YOUR_CALM' strictEqual 'Stream closed with error code 11'
at ClientHttp2Stream.innerFn (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_openssl102_x64/test/common/index.js:701:16)
at ClientHttp2Stream.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_openssl102_x64/test/common/index.js:476:15)
at ClientHttp2Stream.emit (events.js:131:13)
at emitErrorNT (internal/streams/destroy.js:66:8)
at process._tickCallback (internal/process/next_tick.js:115:19)

@addaleax
http2: refer to stream errors by name
aea1523
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
@addaleax
[squash] fixup sequential/ test
a2d745a
@addaleax
addaleaxforce-pushed the http2-error-code-name branch from dce16ef to a2d745aCompareFebruary 24, 2018 19:32
@addaleax

addaleax commented Feb 24, 2018

Copy link
Copy Markdown
MemberAuthor

Thanks, new CI: https://ci.nodejs.org/job/node-test-commit/16480/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2018
@apapirovski

apapirovski commented Mar 4, 2018

Copy link
Copy Markdown
Contributor

Landed in 7bc8eb8

apapirovski pushed a commit that referenced this pull request Mar 4, 2018
@addaleax@apapirovski
http2: refer to stream errors by name
7bc8eb8
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
PR-URL: #18966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins

MylesBorins commented Mar 6, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@targostargos added backport-requested-v9.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v9.x labels Mar 24, 2018
targos pushed a commit to targos/node that referenced this pull request Mar 24, 2018
@addaleax@targos
http2: refer to stream errors by name
a6785dc
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
PR-URL: nodejs#18966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Mar 24, 2018
Closed
targos pushed a commit that referenced this pull request Mar 30, 2018
@addaleax@targos
http2: refer to stream errors by name
441175c
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
Backport-PR-URL: #19579
PR-URL: #18966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Apr 4, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax@MayaLekova
http2: refer to stream errors by name
497849c
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
PR-URL: nodejs#18966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Jun 29, 2018
@addaleax
http2: refer to stream errors by name
bd88858
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
PR-URL: #18966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax
addaleax deleted the http2-error-code-name branch June 29, 2018 23:01
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax@rvagg
http2: refer to stream errors by name
a29cd25
Display the constant name instead of a stream error code
in the error message, because the numerical codes give absolutely
no clue about what happened when an error is emitted.
PR-URL: #18966
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@JungMinuJungMinuJungMinu approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@addaleax@joyeecheung@apapirovski@MylesBorins@jasnell@cjihrig@tniessen@JungMinu@BridgeAR@targos@nodejs-github-bot