Uh oh!
There was an error while loading. Please reload this page.
url: replace "magic" numbers by constants - #19035
Closed
daynin wants to merge 1 commit into
Closed
Conversation
watilde
commented
Feb 27, 2018
Member
MylesBorins
approved these changes
Feb 27, 2018
MylesBorins
left a comment
Contributor
There was a problem hiding this comment.
rubber stamp LGTM if CI passes
watilde
approved these changes
Feb 27, 2018
cjihrig
approved these changes
Feb 28, 2018
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
These changes LGTM, but it seems like there are still quite a few magic numbers in lib/url.js. For example, https://github.com/daynin/node/blob/32c3cb1c145a25efffb2f353d4db314b7952f6ca/lib/url.js#L276-L291
danbev
approved these changes
Feb 28, 2018
dayninforce-pushed
the
url-add-constants
branch
from
February 28, 2018 09:11
32c3cb1 to
46d8af5Comparedaynin
commented
Feb 28, 2018
ContributorAuthor
@cjihrig I replaced remain numbers |
dayninforce-pushed
the
url-add-constants
branch
from
February 28, 2018 10:39
46d8af5 to
ccc8b07Comparejasnell
approved these changes
Feb 28, 2018
watilde
commented
Feb 28, 2018
Member
XadillaX
approved these changes
Mar 1, 2018
benjamingr
approved these changes
Mar 1, 2018
tniessen
approved these changes
Mar 4, 2018
apapirovski
approved these changes
Mar 4, 2018
apapirovski
left a comment
Contributor
There was a problem hiding this comment.
LGTM but there's an incorrect comment that has to be fixed before landing.
Contributor
There was a problem hiding this comment.
This should be commented as \uFEFF, not \u00A0.
daynin
commented
Mar 6, 2018
ContributorAuthor
/cc @nodejs/collaborators Hello! Run CI for this PR, please |
devsnek
commented
Mar 6, 2018
Member
BridgeAR
commented
Mar 11, 2018
Member
Landed in 2f74326 🎉 |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 11, 2018
PR-URL: nodejs#19035 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 20, 2018
PR-URL: #19035 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 20, 2018
PR-URL: #19035 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#19035 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
jasnell
commented
Aug 17, 2018
Member
should this be backported to 8.x? If so, a separate backport PR is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url