Adding assertion for the test in test-event-emitter-subclass

[stenalpjolly]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[stenalpjolly]

@mscdex@richardlau Please review the code

[starkwang]

LGTM

[stenalpjolly]

Who can merge it?

[starkwang]

@stenalpjolly This PR will be hold at least 48-72 hours for waiting input from other Collaborators (refers to COLLABORATOR_GUIDE). If no one requests change for it, this PR will be landed as soon as possible.

[starkwang]

CI: https://ci.nodejs.org/job/node-test-pull-request/13441/

Misclick

[apapirovski]

Ignore.

[apapirovski]

This property isn't declared on the instance but rather the EventEmitter itself. So the test needs to be assert(MyEE.hasOwnProperty('usingDomain');.

See below for a correction...

[richardlau]

This property isn't declared on the instance but rather the EventEmitter itself. So the test needs to be assert(MyEE.hasOwnProperty('usingDomain');.

But that would fail because MyEE inherits usingDomain from EventEmitter.

The myee.hasOwnProperty('usingDomains'); line was added by #18944, which addresses #17403 (comment) where the minimal testcase was:

varassert=require('assert')varEventsModule=require('events')vardescriptor=Object.getOwnPropertyDescriptor(EventsModule,'usingDomains')assert(descriptor)

[apapirovski]

But that would fail because MyEE inherits usingDomain from EventEmitter.

Sorry, thought this code was using _extend not inherits. Either way, myee.hasOwnProperty is incorrect. This should most likely just be assert(EventEmitter.hasOwnProperty('usingDomains')); and be in an entirely different test file than this one.

Or if we want to stick with having it in this file, then use Reflect.has(MyEE, 'usingDomains');.

[BridgeAR]

@stenalpjolly would you be so kind and try to implement the suggestion by @apapirovski? If you need any help, please let me (or any other collaborator) know.

[BridgeAR]

Ping @stenalpjolly

[BridgeAR]

Closing due to no response. @stenalpjolly thanks a lot for your contribution and if you would like to work on this again: please either leave a comment so we can reopen the PR or you can just open a new PR (I recommend to do that instead).