benchmarks: fix benchmark for url

[daynin]

It fixes an error which occurs after running this test:

node benchmark/url/url-searchparams-read.js

Error:

internal/url.js:983
throw new errors.TypeError('ERR_INVALID_THIS', 'URLSearchParams');
^
TypeError [ERR_INVALID_THIS]: Value of "this" must be of type URLSearchParams
at get (internal/url.js:983:13)
at main (/Users/daynin/Documents/projects/node/benchmark/url/url-searchparams-read.js:21:5)
at Benchmark.process.nextTick (/Users/daynin/Documents/projects/node/benchmark/common.js:34:28)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
at Function.Module.runMain (module.js:678:11)
at startup (bootstrap_node.js:187:16)
at bootstrap_node.js:608:3

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

benchmark

[BridgeAR]

It would be great to add a test for the url benchmarks to prevent any further regressions. Would you be so kind and add one?

A alternative way of fixing this would be replacing the fn in the for loop with params[method](param);. I personally would go for that instead.

[daynin]

@BridgeAR I replaced fn by calling params[method]

[daynin]

@BridgeAR tell me pls, how can I add a test for a benchmark?

[BridgeAR]

E.g. https://github.com/nodejs/node/blob/master/test/parallel/test-benchmark-path.js

[daynin]

@BridgeAR

It would be great to add a test for the url benchmarks to prevent any further regressions. Would you be so kind and add one?

Done

[BridgeAR]

Please also add options for all existing options in any url benchmark that exists and pass in a concrete value. Otherwise it would test for all options and that increases the runtime significantly.

So e.g. method, type...

[daynin]

@BridgeAR when I add option like 'method=get' or 'method=' it throws an error:

/Users/daynin/Documents/projects/node/benchmark/url/legacy-vs-whatwg-url-get-prop.js:89
throw new Error(`Unknown method "${method}"`);
^
Error: Unknown method "get"

or

/Users/daynin/Documents/projects/node/benchmark/url/legacy-vs-whatwg-url-get-prop.js:89
throw new Error(`Unknown method "${method}"`);
^
Error: Unknown method ""

Can I specify certain benchmark for the test somehow or avoid these errors?

[apapirovski]

Seems like you're passing in method="get" given the quotation marks in the error? Instead pass in method=get.

[daynin]

@apapirovski I passed 'method=get' as an option. But I think the problem is url-searchparams-read.js has than config:

const bench = common.createBenchmark(main, {
method: ['get', 'getAll', 'has'],
param: ['one', 'two', 'three', 'nonexistent'],
n: [2e7]
})

but legacy-vs-whatwg-url-get-prop.js has that config:

const bench = common.createBenchmark(main, {
type: Object.keys(inputs),
method: ['legacy', 'whatwg'],
n: [1e5]
})

There are two params method with different values

[apapirovski]

Ah, sorry, didn't see the file name you mentioned. I would probably just rename the method to be something else in the legacy benchmark, if that's the only one blocking this.

[daynin]

@apapirovski@BridgeAR done

[BridgeAR]

Not a fan of the churn for this change but the code itself looks good to me.

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/13456/

[apapirovski]

LGTM but needs a typo fix-up before landing.

[apapirovski]

Typo? Should be href, I think.

[daynin]

@apapirovski yeah, of course

[daynin]

@apapirovski fixed

[daynin]

/cc @nodejs/collaborators

Hello! Run CI for this PR, please

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/13535/

[BridgeAR]

Landed in f3257dd 🎉

[jasnell]

Should this be backported to 8.x? If so, a separate backport PR is needed