Uh oh!
There was an error while loading. Please reload this page.
next: Update v8 to 4.3.61.27 - #1909
Closed
targos wants to merge 2 commits into
Closed
Conversation
targos
commented
Jun 6, 2015
Member
- ClosesUpdate V8 in next to 4.3.61.27 #1906
- Still floating @indutny's SealHandleScope patch (will be included in 4.4)
- 70716fd is now included in v8
- Fix for src: disable fast math on arm #1398 is still only in 4.5
Original commit message: api: introduce SealHandleScope When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{nodejs#27766} Should help us identify and fix Handle leaks in core and user-space code. NOTE: Works only in Debug build now, but is still better than nothing. PR-URL: nodejs#1395 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123
commented
Jun 10, 2015
Contributor
cc @bnoordhuis |
trevnorris
commented
Jun 10, 2015
Contributor
Not near my laptop or would do it myself, but let's kick off a CI. Change looks pretty straight forward. |
cjihrig
commented
Jun 10, 2015
Contributor
targos
commented
Jun 15, 2015
MemberAuthor
New URL: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi_old/794/ |
trevnorris
commented
Jun 17, 2015
Contributor
@chrisdickinson Please always leave a reason for closing. |
targos
commented
Jun 19, 2015
MemberAuthor
I'll close it myself in favor of the upgrade to V8 4.4: #1807 (comment) |
chrisdickinson
commented
Jun 19, 2015
Contributor
Ah, this was likely automatically closed by GitHub when I recut next. Sorry I missed it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.