Uh oh!
There was an error while loading. Please reload this page.
doc: update cc list - #19099
Closed
BridgeAR wants to merge 3 commits into
Closed
Conversation
BridgeAR
commented
Mar 2, 2018
MemberAuthor
BridgeAR
commented
Mar 2, 2018
MemberAuthor
I also removed @jbergstroem as I had the feeling that this was outdated and added @rvagg in one place instead. Please correct me if that was wrong. |
| | upgrading c-ares | @jbergstroem | | ||
| | upgrading http-parser | @jbergstroem, @nodejs/http | | ||
| | upgrading libuv | @saghul | | ||
| | upgrading c-ares | @rvagg, | |
| | upgrading http-parser | @jbergstroem, @nodejs/http | | ||
| | upgrading libuv | @saghul | | ||
| | upgrading c-ares | @rvagg, | | ||
| | upgrading http-parser | @nodejs/http nodejs/http2 | |
Contributor
There was a problem hiding this comment.
Nit: missing comma and @ (@nodejs/http nodejs/http2 -> @nodejs/http, @nodejs/http2)?
Leko
approved these changes
Mar 3, 2018
Leko
left a comment
Contributor
There was a problem hiding this comment.
LGTM if vsemozhetbyt’s suggestion reviced
vsemozhetbyt
approved these changes
Mar 3, 2018
lpinca
approved these changes
Mar 3, 2018
BridgeAR
commented
Mar 4, 2018
MemberAuthor
gibfahn
approved these changes
Mar 5, 2018
jasnell
approved these changes
Mar 5, 2018
apapirovski
commented
Mar 6, 2018
Contributor
Landed in aa35074 |
apapirovski pushed a commit
that referenced
this pull request
Mar 6, 2018
PR-URL: #19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 6, 2018
PR-URL: #19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 6, 2018
PR-URL: #19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 6, 2018
PR-URL: #19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 6, 2018
PR-URL: #19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 7, 2018
PR-URL: #19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#19099 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
commented
Aug 17, 2018
Member
There's really no reason to backport this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently created a lot of new teams and added the users that were mentioned here to the corresponding group. This updates almost everything so we do not have individual users but groups to ping.
See #19097
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc