Uh oh!
There was an error while loading. Please reload this page.
dns: add dns trace events - #19157
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
BridgeAR
commented
Apr 9, 2018
Member
Ping @jasnell |
jasnell
commented
Apr 9, 2018
MemberAuthor
Haven't forgotten. Please leave this open |
BridgeAR
commented
Apr 28, 2018
Member
Ping @jasnell |
jasnell
commented
Apr 28, 2018
MemberAuthor
Yep. Please leave this open. Still a work in progress. |
1 task
chinhuang007
commented
Jul 16, 2018
Contributor
@jasnell I created a new PR, took your code, modified it to use nestable async events, and added test code. Please help review. And at the end maybe close this one. |
jasnell
commented
Jul 16, 2018
MemberAuthor
Excellent. I'll take a look in the next day or two |
jasnell
commented
Jul 20, 2018
MemberAuthor
Closing this in favor of the new PR :-) |
chinhuang007 added a commit
to chinhuang007/node
that referenced
this pull request
Aug 20, 2018
Add trace points to dns under node.dns.native category. Emit trace events for dns operations. Use the nestable async events instead of deprecated ones. Include test code to verify the trace log. The trace name is stored as const char* class variable. The test code is to check each operation in separate sync processes. Refs: nodejs#19157
addaleax pushed a commit
that referenced
this pull request
Sep 2, 2018
Add trace points to dns under node.dns.native category. Emit trace events for dns operations. Use the nestable async events instead of deprecated ones. Include test code to verify the trace log. The trace name is stored as const char* class variable. The test code is to check each operation in separate sync processes. Refs: #19157 PR-URL: #21840 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 3, 2018
Add trace points to dns under node.dns.native category. Emit trace events for dns operations. Use the nestable async events instead of deprecated ones. Include test code to verify the trace log. The trace name is stored as const char* class variable. The test code is to check each operation in separate sync processes. Refs: #19157 PR-URL: #21840 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 6, 2018
Add trace points to dns under node.dns.native category. Emit trace events for dns operations. Use the nestable async events instead of deprecated ones. Include test code to verify the trace log. The trace name is stored as const char* class variable. The test code is to check each operation in separate sync processes. Refs: #19157 PR-URL: #21840 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
node.dnstrace event category.Emit trace events for dns operations.
Note: this still needs a test
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes