Skip to content

src: fix deprecation id for non-string env value - #19209

Closed
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:fix-process-dep-number
Closed

src: fix deprecation id for non-string env value#19209
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:fix-process-dep-number

Conversation

@thefourtheye

@thefourtheyethefourtheye commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

This is a follow-up of #18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@thefourtheye
src: fix deprecation id for non-string env value
132cef0
This is a follow-up of nodejs#18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 7, 2018
@TimothyGuTimothyGu added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Mar 7, 2018
@TimothyGu

TimothyGu commented Mar 7, 2018

Copy link
Copy Markdown
Member

Sorry, my bad.

@thefourtheye

thefourtheye commented Mar 7, 2018

Copy link
Copy Markdown
ContributorAuthor

CI Run: https://ci.nodejs.org/job/node-test-pull-request/13575/

@TimothyGu

TimothyGu commented Mar 7, 2018•
edited
Loading

Copy link
Copy Markdown
Member

linuxONE + linter are passing. For the interest of time I've landed this in 50b1cb3.

TimothyGu pushed a commit that referenced this pull request Mar 7, 2018
@thefourtheye@TimothyGu
src: fix deprecation id for non-string env value
50b1cb3
This is a follow-up of #18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.
PR-URL: #19209
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@thefourtheye
thefourtheye deleted the fix-process-dep-number branch March 7, 2018 19:34
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@thefourtheye@MayaLekova
src: fix deprecation id for non-string env value
6b98a6a
This is a follow-up of nodejs#18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.
PR-URL: nodejs#19209
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thefourtheye@TimothyGu@joyeecheung@targos@nodejs-github-bot