Uh oh!
There was an error while loading. Please reload this page.
http2: fixes error handling - #19232
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
mcollina
requested review from
addaleax, apapirovski and jasnell
and removed request for
jasnellMarch 8, 2018 15:42
mcollina
commented
Mar 8, 2018
MemberAuthor
cc @nodejs/http2 |
mcollina
commented
Mar 8, 2018
MemberAuthor
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991
jasnell
approved these changes
Mar 8, 2018
mcollinaforce-pushed
the
fixed-error-handling
branch
from
March 8, 2018 17:00
bf33cfc to
80f9390Comparemcollina
commented
Mar 8, 2018
MemberAuthor
trivikr
approved these changes
Mar 8, 2018
mcollina
commented
Mar 12, 2018
MemberAuthor
Landed in 8403f00 |
mcollina added a commit
that referenced
this pull request
Mar 12, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: #14991 PR-URL: #19232 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Mar 20, 2018
Contributor
This is causing a linter error on v9.x Should this be backported to |
mcollina
commented
Mar 20, 2018
MemberAuthor
on its way. |
mcollina added a commit
to mcollina/node
that referenced
this pull request
Mar 20, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
mcollina
commented
Mar 20, 2018
MemberAuthor
Backport to 9.x in #19478. |
mcollina added a commit
to mcollina/node
that referenced
this pull request
Mar 21, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: #14991 Backport-PR-URL: #19478 PR-URL: #19232 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be no default error handling when using Http2Stream.
All errors will end up in
'streamError'on the server anyway,but they are emitted on
'stream'as well, otherwise some errorconditions are impossible to debug.
See: #14991
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes