Skip to content

tools: make test-npm work without global npm - #1926

Merged
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:allow-test-npm-without-installed-npm
Jun 17, 2015
Merged

tools: make test-npm work without global npm#1926
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:allow-test-npm-without-installed-npm

Conversation

@Fishrock123

@Fishrock123Fishrock123 commented Jun 9, 2015

Copy link
Copy Markdown
Contributor

Calling the tests independently removes the dependancy on npm internally trying to call npm run-script for test-all.

R= @othiym23 / @mhdawson?

@Fishrock123Fishrock123 added test Issues and PRs related to the tests. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jun 9, 2015
@Fishrock123Fishrock123 mentioned this pull request Jun 12, 2015
Closed
@Fishrock123

Fishrock123 commented Jun 15, 2015

Copy link
Copy Markdown
ContributorAuthor

cc @nodejs/build

@rvagg

rvagg commented Jun 16, 2015

Copy link
Copy Markdown
Member

lgtm if you're confirming it works

@Fishrock123

Fishrock123 commented Jun 16, 2015

Copy link
Copy Markdown
ContributorAuthor

It does definitely work, and also without a global npm.

@mhdawson

mhdawson commented Jun 16, 2015

Copy link
Copy Markdown
Member

lgtm as it mirrors https://github.com/mhdawson/node/commit/859e4eec65544be62d2dad1cbea80bf097e48756

@Fishrock123
tools: make test-npm work without global npm
91dfb5e
Futher discussion at nodejs/node-v0.x-archive#25294
PR-URL: nodejs#1926
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Fishrock123
Fishrock123force-pushed the allow-test-npm-without-installed-npm branch from ef5c9c3 to 91dfb5eCompareJune 17, 2015 16:28
@Fishrock123
Fishrock123 merged commit 91dfb5e into nodejs:masterJun 17, 2015
@Fishrock123

Fishrock123 commented Jun 17, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks!

@rvaggrvagg mentioned this pull request Jun 18, 2015
Closed
@mhdawsonmhdawson mentioned this pull request Apr 15, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fishrock123@rvagg@mhdawson