Uh oh!
There was an error while loading. Please reload this page.
vm: migrate isContext to internal/errors - #19268
Closed
dustinnewman wants to merge 1 commit into
Closed
Conversation
TimothyGu
commented
Mar 9, 2018
Member
TimothyGu
approved these changes
Mar 9, 2018
jasnell
approved these changes
Mar 9, 2018
devsnek
approved these changes
Mar 10, 2018
maclover7
approved these changes
Mar 10, 2018
joyeecheung
approved these changes
Mar 10, 2018
| } | ||
| function isContext(sandbox) { | ||
| if (arguments.length < 1) { |
Member
There was a problem hiding this comment.
Do we need this one though? If sandbox is undefined, it will show up as a ERR_INVALID_ARG_TYPE as well, it seems rare that someone would just do “isContext()”
lpinca
approved these changes
Mar 10, 2018
hiroppy
approved these changes
Mar 10, 2018
cjihrig
approved these changes
Mar 10, 2018
BridgeAR
approved these changes
Mar 11, 2018
2 tasks
targos
reviewed
Mar 17, 2018
| throw new ERR_MISSING_ARGS('sandbox'); | ||
| } | ||
| if (typeof sandbox !== 'object' && typeof sandbox !== 'function' || |
Member
There was a problem hiding this comment.
I'm not sure we want to accept functions?
Member
There was a problem hiding this comment.
I believe that’s just for compatibility: the original ->IsObject() test accepts functions.
Member
Member
targos pushed a commit
that referenced
this pull request
Mar 22, 2018
PR-URL: #19268 Refs: #18106 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
commented
Mar 22, 2018
Member
Landed in 49b2969 |
TimothyGu added a commit
to TimothyGu/node
that referenced
this pull request
Mar 29, 2018
The documentation states: > This is only used for strict compliance with the API specification > (which in some cases may accept func(undefined) but not func()). In > most native Node.js APIs, func(undefined) and func() are treated > identically, and the ERR_INVALID_ARG_TYPE error code may be used > instead. Refs: nodejs#19268 (comment)
3 tasks
MylesBorins
commented
Apr 2, 2018
Contributor
was CITGM run against this? |
TimothyGu
commented
Apr 2, 2018
Member
No, I don't think anyone thought about running it. Is CITGM broken right now? |
MylesBorins
commented
Apr 2, 2018
Contributor
we should generally run for semver-major. Have not checked yet but noticed that a related PR #19398 was breaking stuff. Have not checked citgm against master in a while myself. Can take a peek this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #18106
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes