Uh oh!
There was an error while loading. Please reload this page.
doc: add chalker as collaborator - #1927
Conversation
Fishrock123
commented
Jun 9, 2015
LGTM |
ChALkeR
commented
Jun 9, 2015
Updated to the actual gitconfig name (as suggested in IRC) and GitHub username. |
bnoordhuis
commented
Jun 9, 2015
LGTM and welcome aboard. |
jbergstroem
commented
Jun 9, 2015
LGTM! |
rlidwka
commented
Jun 9, 2015
That's the first fully non-ascii name we'll have in README. Is everybody okay with that? |
vkurchatkin
commented
Jun 9, 2015
Yeah, it's probably better to have it transliterated |
ChALkeR
commented
Jun 9, 2015
I asked in the IRC about that and said that I could take one of two options for everything to match:
I was told (in IRC) by @bnoordhuis that the first variant should be preferred because of that's how it is mentioned the git history already. I will hold off merging this until more people review this. |
ChALkeR
commented
Jun 9, 2015
@vkurchatkin It was initially transliterated in this PR, I was told not to. |
jbergstroem
commented
Jun 9, 2015
What's the counter argument against cyrillic? I don't have a strong opinion for either but the history reference @bnoordhuis brought up makes sense to me. |
rlidwka
commented
Jun 9, 2015
People who aren't familiar with the language won't be able to read it, figure out how to pronounce it, and check if it's been copy-pasted to |
vkurchatkin
commented
Jun 9, 2015
+1 |
ChALkeR
commented
Jun 9, 2015
@rlidwka@vkurchatkin Just for reference:
Copy-pasting and checking the «Reviewed-By» field was the reason why I was asked to use a single variant everywhere, and this is why I changed the original PR in the first place. |
Fishrock123
commented
Jun 10, 2015
I'm not sure, I'm ok with having Cyrillic / etc character names in the readme, although, I would prefer something I can begin to pronounce. :) Perhaps a compromise could be made where we have: |
chrisdickinson
commented
Jun 10, 2015
I am ok with it – those of us who can't read it can always copy-paste it, or this might be a good motivator for us to pick up Cyrillic! :) |
tellnes
commented
Jun 10, 2015
I'd go for both cyrillic and translated version like @Fishrock123 suggests. |
jbergstroem
commented
Jun 11, 2015
I'm not a fan of keeping this PR (which is supposed to be the welcoming step) open for a slightly different discussion than what the PR itself accomplishes. I count enough LGTM's to merge -- how about we open a discussion elsewhere for improving README.md (and/or .gitconfig) in terms of i18n? |
brendanashworth
commented
Jun 12, 2015
+1 for @jbergstroem. Collaborator PRs are more symbolic, not really a place for this sort of discussion. Anyways.. if we want to get technical and argue, other alphabets around the world carry letters and sounds that don't have English / Latinized equivalents. The "Latinize everything" approach wouldn't scale to lots of languages - just because Cyrillic is comparably similar doesn't mean we should make our decision based only off of this. (oh, and Cyrillic is easy to learn 😉) |
Using the non-transliterated name as requested. The transliteration is "Nikita Skovoroda" (first and last name), if anyone will want to organize non-ASCII names. PR-URL: nodejs#1927 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
ChALkeR
commented
Jun 13, 2015
Ok, I am merging this as it is now, marking this as reviewed by people who reviewed the current version. |
PR-URL: #1927