Skip to content

test: delete test-regress-GH-4948 - #19279

Closed
ryzokuken wants to merge 1 commit into
nodejs:masterfrom
ryzokuken:test/delete-4948
Closed

test: delete test-regress-GH-4948#19279
ryzokuken wants to merge 1 commit into
nodejs:masterfrom
ryzokuken:test/delete-4948

Conversation

@ryzokuken

@ryzokukenryzokuken commented Mar 11, 2018•
edited by lpinca
Loading

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 11, 2018
@ryzokukenryzokuken changed the title test: delete test/parallel/test-regress-GH-4948test: delete test-regress-GH-4948Mar 11, 2018
@lpinca

lpinca commented Mar 11, 2018

Copy link
Copy Markdown
Member

Little background here.
This test was introduced in https://github.com/nodejs/node-v0.x-archive/pull/4948/files. At that time IncomingMessage.prototype._dump() was setting this.socket.parser.incoming to null. This no longer happens so I think the test is useless as it's not testing anything.

lpinca
lpinca approved these changes Mar 11, 2018
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@lpinca

lpinca commented Mar 11, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13620/

@ryzokuken

ryzokuken commented Mar 11, 2018

Copy link
Copy Markdown
ContributorAuthor

@lpinca any idea why so many tests failed? I don't this should result in any test failure. Flaky tests?

@lpinca

lpinca commented Mar 11, 2018

Copy link
Copy Markdown
Member

Yes, failures seem unrelated. I don't see how removing a test make others fail.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2018
@lpinca

lpinca commented Mar 13, 2018

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/255/

@lpinca

lpinca commented Mar 13, 2018

Copy link
Copy Markdown
Member

Landed in 52e869b.

lpinca pushed a commit that referenced this pull request Mar 13, 2018
@ryzokuken@lpinca
test: delete test/parallel/test-regress-GH-4948
52e869b
PR-URL: #19279
Refs: #19275 (comment)
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpincalpinca closed this Mar 13, 2018
targos pushed a commit that referenced this pull request Mar 17, 2018
@ryzokuken@targos
test: delete test/parallel/test-regress-GH-4948
9a08f12
PR-URL: #19279
Refs: #19275 (comment)
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@ryzokuken@MylesBorins
test: delete test/parallel/test-regress-GH-4948
11a0ef5
PR-URL: #19279
Refs: #19275 (comment)
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@ryzokuken@MayaLekova
test: delete test/parallel/test-regress-GH-4948
bd5de01
PR-URL: nodejs#19279
Refs: nodejs#19275 (comment)
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ryzokuken@lpinca@jasnell@gireeshpunathil@BridgeAR@BethGriggs@nodejs-github-bot