Skip to content

deps: patch V8 to 6.5.254.38 - #19303

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v8-6.5.254.36
Closed

deps: patch V8 to 6.5.254.38#19303
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v8-6.5.254.36

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Mar 12, 2018

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Mar 12, 2018
@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

Looks like we have a failure on ppc-be
/cc @nodejs/platform-ppc @nodejs/v8

15:11:39 === cctest/test-run-wasm-simd/RunWasm_SimdLoadStoreLoad_compiled ===
15:11:39 --- stderr ---
15:11:39 Received signal 11 SEGV_MAPERR 000000000018
15:11:39 15:11:39 ==== C stack trace ===============================

@targos

Copy link
Copy Markdown
Member

It's expected. ppc-be is unsupported since Node 8. We have to ignore this failure until the job is updated to stop running on this platform

@Flarna

Copy link
Copy Markdown
Member

If you could update to 6.5.254.37 instead #19200 would be fixed too...

@MylesBorinsMylesBorins changed the title deps: patch V8 to 6.5.254.36deps: patch V8 to 6.5.254.38Mar 13, 2018
@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

bumped to 6.5.254.38
CI: https://ci.nodejs.org/job/node-test-pull-request/13662/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1263/

@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

weird new failure on ppcle

not ok 654 parallel/test-http-client-timeout-agent
---
duration_ms: 0.721
severity: fail
stack: |-
res#0 data:0
res#0 end
res#2 data:2
res#2 end
res#4 data:4
res#4 end
res#6 data:6
res#6 end
res#8 data:8
res#8 end
res#10 data:10
res#10 end
res#12 data:12
res#12 end
res#14 data:14
res#14 end
res#16 data:16
res#16 end
res#18 data:18
res#18 end
res#20 data:20
res#20 end
res#22 data:22
res#22 end
res#24 data:24
res#24 end
res#26 data:26
res#26 end
res#28 data:28
res#28 end
req#1 timeout
req#3 timeout
req#5 timeout
req#7 timeout
req#9 timeout
req#11 timeout
req#13 timeout
req#15 timeout
req#17 timeout
req#19 timeout
req#21 timeout
req#23 timeout
req#25 timeout
req#27 timeout
req#29 timeout
req#0 timeout
req#28 close
req#26 close
req#24 close
req#22 close
req#20 close
req#18 close
req#16 close
req#14 close
req#12 close
req#10 close
req#8 close
req#6 close
req#4 close
req#2 close
req#0 close
req#29 error
req#29 close
req#27 error
req#27 close
req#25 error
req#25 close
req#23 error
req#23 close
req#21 error
req#21 close
req#19 error
req#19 close
req#17 error
req#17 close
req#15 error
req#15 close
req#13 error
req#13 close
req#11 error
req#11 close
req#9 error
req#9 close
req#7 error
req#7 close
req#5 error
req#5 close
req#3 error
req#3 close
req#1 error
req#1 close
done=31 sent=30
assert.js:80
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: timeout on http request called too much
at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/test/parallel/test-http-client-timeout-agent.js:94:10)
at process.emit (events.js:187:15)

/cc @nodejs/platform-ppc

@MylesBorins

MylesBorins commented Mar 14, 2018

Copy link
Copy Markdown
ContributorAuthor

@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

Extra PPC test passed. The failing ppc test for V8-CI is expected

Landed in 040dd24

MylesBorins added a commit that referenced this pull request Mar 14, 2018
PR-URL: #19303
Refs: v8/v8@6.5.254.31...6.5.254.38
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@MylesBorins@targos@Flarna@danbev@cjihrig@nodejs-github-bot