Skip to content

doc: update username and email - #19338

Closed
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/modify-my-account
Closed

doc: update username and email#19338
hiroppy wants to merge 1 commit into
nodejs:masterfrom
hiroppy:feature/modify-my-account

Conversation

@hiroppy

@hiroppyhiroppy commented Mar 14, 2018

Copy link
Copy Markdown
Member

Modify Yuta Hiroto's account information.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2018
@hiroppy

hiroppy commented Mar 14, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/258/

@TrottTrott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 14, 2018
MylesBorins
MylesBorins approved these changes Mar 14, 2018
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiroppy

hiroppy commented Mar 14, 2018

Copy link
Copy Markdown
MemberAuthor

This pr does not need to wait 24h so I wold like to merge:) Thank you for reviewing.

hiroppy added a commit that referenced this pull request Mar 14, 2018
@hiroppy
doc: update username and email
0a56a1b
PR-URL: #19338
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@hiroppy

hiroppy commented Mar 14, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 0a56a1b.

@hiroppyhiroppy closed this Mar 14, 2018
@hiroppy
hiroppy deleted the feature/modify-my-account branch March 14, 2018 11:55
targos pushed a commit that referenced this pull request Mar 17, 2018
@hiroppy@targos
doc: update username and email
f2f3ef2
PR-URL: #19338
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@hiroppy@MylesBorins
doc: update username and email
7f652c2
PR-URL: #19338
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@hiroppy@MayaLekova
doc: update username and email
e6405c1
PR-URL: nodejs#19338
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@hiroppy@BethGriggs
doc: update username and email
5b9af6e
PR-URL: #19338
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@danbevdanbevdanbev approved these changes
@MylesBorinsMylesBorinsMylesBorins approved these changes
@yosuke-furukawayosuke-furukawayosuke-furukawa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@hiroppy@danbev@jasnell@MylesBorins@yosuke-furukawa@Trott@gireeshpunathil@BridgeAR@tniessen@BethGriggs@nodejs-github-bot