stream: improve stream creation performance by mscdex · Pull Request #19401 · nodejs/node

mscdex · 2018-03-17T00:40:56Z

 confidence improvement accuracy (*) (**) (***)
streams/creation.js kind='duplex' n=50000000 *** 16.72 % ±0.83% ±1.11% ±1.45%
streams/creation.js kind='readable' n=50000000 *** 17.56 % ±0.91% ±1.21% ±1.58%
streams/creation.js kind='transform' n=10000000 *** 12.23 % ±1.29% ±1.72% ±2.27%
streams/creation.js kind='writable' n=50000000 *** 18.11 % ±0.86% ±1.14% ±1.48%

CI: https://ci.nodejs.org/job/node-test-pull-request/13712/

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

mcollina

LGTM.

Nice technique, I've tried to speed this up once and failed.

Do you think we could something similar for Readable?

mscdex · 2018-03-18T12:19:53Z

Do you think we could something similar for Readable?

Not the exact same thing since Readable never does instanceof Stream.Duplex more than once, but I do have something else that may help...

lpinca · 2018-03-18T13:34:50Z

Tiny nit: subsystem in commit title should be "stream" or at least that seem more common than "streams"

mscdex · 2018-03-21T09:00:05Z

Added improvement for stream.Readable.

New CI: https://ci.nodejs.org/job/node-test-pull-request/13800/

mcollina · 2018-03-21T14:56:36Z

This is superb. LGTM.

I expect the advantage to be consistent also in previous version with turbofan, so we should think about measuring and backporting to 8 as well.

lpinca · 2018-03-21T15:05:28Z

@mcollina you mean v6.x not v8.x right?

mcollina · 2018-03-21T15:09:27Z

I mean, we should look to backport it to 8.x. I wouldn't backport it to 6.x

addaleax · 2018-03-23T12:40:34Z

Landed in b41ed29

PR-URL: #19401 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

Notable changes: * cluster: - Add support for `NODE_OPTIONS="--inspect"` (Sameer Srivastava) #19165 * crypto: - Expose the public key of a certificate (Hannes Magnusson) #17690 * n-api: - Add `napi_fatal_exception` to trigger an `uncaughtException` in JavaScript (Mathias Buus) #19337 * path: - Fix regression in `posix.normalize` (Michaël Zasso) #19520 * stream: - Improve stream creation performance (Brian White) #19401 * Added new collaborators - [BethGriggs](https://github.com/BethGriggs) Beth Griggs

This is a security release. All Node.js users should consult the security release summary at: https://nodejs.org/en/blog/vulnerability/march-2018-security-releases/ for details on patched vulnerabilities. Fixes for the following CVEs are included in this release: * CVE-2018-7158 * CVE-2018-7159 * CVE-2018-7160 Notable changes: * Upgrade to OpenSSL 1.0.2o: Does not contain any security fixes that are known to impact Node.js. * **Fix for inspector DNS rebinding vulnerability (CVE-2018-7160)**: A malicious website could use a DNS rebinding attack to trick a web browser to bypass same-origin-policy checks and allow HTTP connections to localhost or to hosts on the local network, potentially to an open inspector port as a debugger, therefore gaining full code execution access. The inspector now only allows connections that have a browser `Host` value of `localhost` or `localhost6`. * **Fix for `'path'` module regular expression denial of service (CVE-2018-7158)**: A regular expression used for parsing POSIX an Windows paths could be used to cause a denial of service if an attacker were able to have a specially crafted path string passed through one of the impacted `'path'` module functions. * **Reject spaces in HTTP `Content-Length` header values (CVE-2018-7159)**: The Node.js HTTP parser allowed for spaces inside `Content-Length` header values. Such values now lead to rejected connections in the same way as non-numeric values. * **Update root certificates**: 5 additional root certificates have been added to the Node.js binary and 30 have been removed. * cluster: - Add support for `NODE_OPTIONS="--inspect"` (Sameer Srivastava) #19165 * crypto: - Expose the public key of a certificate (Hannes Magnusson) #17690 * n-api: - Add `napi_fatal_exception` to trigger an `uncaughtException` in JavaScript (Mathias Buus) #19337 * path: - Fix regression in `posix.normalize` (Michaël Zasso) #19520 * stream: - Improve stream creation performance (Brian White) #19401 * Added new collaborators - [BethGriggs](https://github.com/BethGriggs) Beth Griggs PR-URL: https://github.com/nodejs-private/node-private/pull/111

This is a security release. All Node.js users should consult the security release summary at: https://nodejs.org/en/blog/vulnerability/march-2018-security-releases/ for details on patched vulnerabilities. Fixes for the following CVEs are included in this release: * CVE-2018-7158 * CVE-2018-7159 * CVE-2018-7160 Notable changes: * Upgrade to OpenSSL 1.0.2o: Does not contain any security fixes that are known to impact Node.js. * **Fix for inspector DNS rebinding vulnerability (CVE-2018-7160)**: A malicious website could use a DNS rebinding attack to trick a web browser to bypass same-origin-policy checks and allow HTTP connections to localhost or to hosts on the local network, potentially to an open inspector port as a debugger, therefore gaining full code execution access. The inspector now only allows connections that have a browser `Host` value of `localhost` or `localhost6`. * **Fix for `'path'` module regular expression denial of service (CVE-2018-7158)**: A regular expression used for parsing POSIX an Windows paths could be used to cause a denial of service if an attacker were able to have a specially crafted path string passed through one of the impacted `'path'` module functions. * **Reject spaces in HTTP `Content-Length` header values (CVE-2018-7159)**: The Node.js HTTP parser allowed for spaces inside `Content-Length` header values. Such values now lead to rejected connections in the same way as non-numeric values. * **Update root certificates**: 5 additional root certificates have been added to the Node.js binary and 30 have been removed. * cluster: - Add support for `NODE_OPTIONS="--inspect"` (Sameer Srivastava) nodejs/node#19165 * crypto: - Expose the public key of a certificate (Hannes Magnusson) nodejs/node#17690 * n-api: - Add `napi_fatal_exception` to trigger an `uncaughtException` in JavaScript (Mathias Buus) nodejs/node#19337 * path: - Fix regression in `posix.normalize` (Michaël Zasso) nodejs/node#19520 * stream: - Improve stream creation performance (Brian White) nodejs/node#19401 * Added new collaborators - [BethGriggs](https://github.com/BethGriggs) Beth Griggs PR-URL: https://github.com/nodejs-private/node-private/pull/111

mscdex added stream Issues and PRs related to the stream subsystem. performance Issues and PRs related to the performance of Node.js. labels Mar 17, 2018

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 17, 2018

addaleax approved these changes Mar 17, 2018
View reviewed changes

JungMinu approved these changes Mar 17, 2018
View reviewed changes

jasnell requested a review from mcollina March 17, 2018 16:48

mcollina approved these changes Mar 17, 2018
View reviewed changes

jasnell approved these changes Mar 18, 2018
View reviewed changes

lpinca approved these changes Mar 18, 2018
View reviewed changes

lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2018

mscdex added the wip Issues and PRs that are still a work in progress. label Mar 18, 2018

stream: improve stream creation performance
6ba37f5

mscdex force-pushed the perf-stream-Writable-creation branch from af767c4 to 6ba37f5Compare March 21, 2018 08:57

mscdex removed the wip Issues and PRs that are still a work in progress. label Mar 21, 2018

mscdex changed the title ~~streams: improve Writable creation performance~~stream: improve stream creation performanceMar 21, 2018

mcollina added dont-land-on-v4.x labels Mar 21, 2018

TimothyGu approved these changes Mar 22, 2018
View reviewed changes

addaleax closed this Mar 23, 2018

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2018

mscdex deleted the perf-stream-Writable-creation branch March 23, 2018 18:42

Navigation Menu

Uh oh!

Uh oh!

stream: improve stream creation performance - #19401

stream: improve stream creation performance#19401
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:perf-stream-Writable-creation

mscdex commented Mar 17, 2018•
edited
Loading

Uh oh!

mcollina left a comment

Uh oh!

mscdex commented Mar 18, 2018

Uh oh!

lpinca commented Mar 18, 2018•
edited
Loading

Uh oh!

mscdex commented Mar 21, 2018

Uh oh!

mcollina commented Mar 21, 2018

Uh oh!

lpinca commented Mar 21, 2018

Uh oh!

mcollina commented Mar 21, 2018

Uh oh!

addaleax commented Mar 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

mscdex commented Mar 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mscdex commented Mar 18, 2018

Uh oh!

lpinca commented Mar 18, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mscdex commented Mar 21, 2018

Uh oh!

mcollina commented Mar 21, 2018

Uh oh!

lpinca commented Mar 21, 2018

Uh oh!

mcollina commented Mar 21, 2018

Uh oh!

addaleax commented Mar 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mscdex commented Mar 17, 2018•
edited
Loading

lpinca commented Mar 18, 2018•
edited
Loading