Skip to content

net: emit error on invalid address family - #19415

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:19407
Mar 19, 2018
Merged

net: emit error on invalid address family#19415
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:19407

Conversation

@cjihrig

@cjihrigcjihrig commented Mar 17, 2018

Copy link
Copy Markdown
Contributor

This commit adds proper error handling to net.connect() when a custom lookup() function returns an invalid address family.

Fixes: #19407

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem. labels Mar 17, 2018
richardlau
richardlau reviewed Mar 17, 2018
View reviewed changes
Comment threadtest/parallel/test-net-options-lookup.js Outdated

@richardlaurichardlauMar 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.expectsError?

@targostargos mentioned this pull request Mar 17, 2018
Closed
4 tasks
@cjihrig

cjihrig commented Mar 19, 2018

Copy link
Copy Markdown
ContributorAuthor

Updated to use common.expectsError(). CI: https://ci.nodejs.org/job/node-test-pull-request/13743/

@cjihrig
net: emit error on invalid address family
7c73cd4
This commit adds proper error handling to net.connect() when
a custom lookup() function returns an invalid address family.
PR-URL: nodejs#19415Fixes: nodejs#19407
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
cjihrig merged commit 7c73cd4 into nodejs:masterMar 19, 2018
@cjihrig
cjihrig deleted the 19407 branch March 19, 2018 18:51
@MylesBorins

MylesBorins commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@cjihrig@BridgeAR
net: emit error on invalid address family
a37beba
This commit adds proper error handling to net.connect() when
a custom lookup() function returns an invalid address family.
PR-URL: nodejs#19415Fixes: nodejs#19407
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@santigimenosantigimenosantigimeno approved these changes
@targostargostargos approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@XadillaXXadillaXXadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@cjihrig@MylesBorins@jasnell@addaleax@santigimeno@targos@XadillaX@joyeecheung@richardlau@nodejs-github-bot