Uh oh!
There was an error while loading. Please reload this page.
test: improve tty.getColorDepth coverage - #19446
Closed
BridgeAR wants to merge 2 commits into
Closed
Conversation
BridgeAR
commented
Mar 19, 2018
MemberAuthor
lpinca
commented
Mar 19, 2018
Member
Lies 😉 |
BridgeARforce-pushed
the
increase-test-coverage
branch
from
March 20, 2018 00:32
f0e6390 to
5fe0953CompareBridgeAR
commented
Mar 20, 2018
MemberAuthor
lpinca
approved these changes
Mar 20, 2018
jasnell
approved these changes
Mar 20, 2018
| Object.defineProperty(process, 'platform', platform); | ||
| } | ||
| process.env.NODE_DISABLE_COLORS = NODE_DISABLE_COLORS; |
Member
There was a problem hiding this comment.
This test fails when being run with NODE_PENDING_DEPRECATION=1, because NODE_DISABLE_COLORS can be undefined at this point.
I guess you could just drop this line? Setting an environment variable at the end of the script shouldn’t make a difference anyway, I think…
BridgeAR
commented
Mar 24, 2018
MemberAuthor
Comment addressed. PTAL. |
Leko
approved these changes
Mar 26, 2018
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Mar 27, 2018
PR-URL: nodejs#19446 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BridgeAR
commented
Mar 27, 2018
MemberAuthor
Landed in ce2ed58 |
Member
Should only be backported to Edit: wrong reference |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#19446 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tty.getColorDepthfunction has only a very basic coverage. This almost fully covers that function (there are some parts that can not really be tested).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes