Uh oh!
There was an error while loading. Please reload this page.
tools: fix logic nit in tools/doc/generate.js - #19475
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
commented
Mar 20, 2018
ContributorAuthor
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/278/ Let me know if we need full CI for this. |
cjihrig
approved these changes
Mar 20, 2018
lpinca
approved these changes
Mar 20, 2018
vsemozhetbyt
commented
Mar 20, 2018
ContributorAuthor
Landed in 14460d5 |
vsemozhetbyt added a commit
that referenced
this pull request
Mar 20, 2018
PR-URL: #19475 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 22, 2018
PR-URL: #19475 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Aug 17, 2018
PR-URL: #19475 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesI am not sure if there is a reason to throw before (instead of) the output for HTML format and throw after (with) the output for JSON format. Let me know if I miss something.