Skip to content

[v6.x backport] stream: remove unreachable code - #19483

Closed
lpinca wants to merge 2 commits into
nodejs:v6.x-stagingfrom
lpinca:backport/18239
Closed

[v6.x backport] stream: remove unreachable code #19483
lpinca wants to merge 2 commits into
nodejs:v6.x-stagingfrom
lpinca:backport/18239

Conversation

@lpinca

@lpincalpinca commented Mar 20, 2018

Copy link
Copy Markdown
Member

This is a backport of #18239.

@lpinca
stream: remove unreachable code
95abb99
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.
PR-URL: nodejs#18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@lpinca
test: use correct size in test-stream-buffer-list
e60828e
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.
PR-URL: nodejs#18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@lpinca

lpinca commented Mar 20, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/13771/

@lpincalpinca mentioned this pull request Mar 20, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@lpinca@MylesBorins
stream: remove unreachable code
cb0f658
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.
Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@lpinca@MylesBorins
test: use correct size in test-stream-buffer-list
708931d
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.
Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins

MylesBorins commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

landed in 8427ec6...708931d

@lpinca
lpinca deleted the backport/18239 branch March 21, 2018 06:07
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@lpinca@MylesBorins
stream: remove unreachable code
eeaecce
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.
Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@lpinca@MylesBorins
test: use correct size in test-stream-buffer-list
e22a645
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.
Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@lpinca@MylesBorins
stream: remove unreachable code
8f830ca
To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.
Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@lpinca@MylesBorins
test: use correct size in test-stream-buffer-list
5bcf668
The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.
Backport-PR-URL: #19483
PR-URL: #18239
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lpinca@MylesBorins@nodejs-github-bot