Uh oh!
There was an error while loading. Please reload this page.
lib: rename js source to lower snake_case - #19556
Closed
danbev wants to merge 3 commits into
Closed
Conversation
addaleax
approved these changes
Mar 23, 2018
devsnek
commented
Mar 23, 2018
Member
in https://github.com/nodejs/node/tree/master/lib/internal/modules/esm everything is named in that style, i suppose they should also be renamed? |
trivikr
approved these changes
Mar 24, 2018
TimothyGu
commented
Mar 24, 2018
Member
jasnell
approved these changes
Mar 24, 2018
vkurchatkin
commented
Mar 24, 2018
Contributor
It is named like this because it exports a single class. |
danbev
commented
Mar 25, 2018
ContributorAuthor
I did notice this and that is why I brought it up. Do we want to keep it like this or should we rename all JavaScript source files to lowercase? (I'd prefer to rename) |
devsnek
commented
Mar 25, 2018
Member
i've had enough trouble with caseless filesystems to wholeheartedly recommend keeping everything as snake_case |
danbev
commented
Mar 26, 2018
ContributorAuthor
danbev
commented
Mar 26, 2018
ContributorAuthor
node-test-commit-linuxone failure looks unrelatedBuilding addon /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/addons-napi/test_function/if [ -x /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/./node ] && [ -e /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/./node ]; then /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/./node tools/doc/generate.js --format=json doc/api/cluster.md > out/doc/api/cluster.json; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` tools/doc/generate.js --format=json doc/api/cluster.md > out/doc/api/cluster.json; else echo "No available node, cannot run \"node tools/doc/generate.js --format=json doc/api/cluster.md > out/doc/api/cluster.json\""; exit 1; fi; SOLINK_MODULE(target) Release/obj.target/binding.node COPY Release/binding.nodemake[2]: Leaving directory `/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/addons/hello-world/build'make[2]: write errorgyp ERR! build error gyp ERR! stack Error: `make` failed with exit code: 1gyp ERR! stack at ChildProcess.onExit (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/deps/npm/node_modules/node-gyp/lib/build.js:258:23)gyp ERR! stackmake[1]: gyp info it worked if it ends with ok |
TimothyGu
approved these changes
Mar 26, 2018
This commit renames all JavaScript source files in lib/internal/modules to lower snake_case.
trivikr
commented
Mar 28, 2018
Member
This code looks good to land |
danbev
commented
Mar 28, 2018
ContributorAuthor
Landed in f2b1079. |
danbev added a commit
that referenced
this pull request
Mar 28, 2018
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: #19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos
commented
Apr 2, 2018
Member
Should this be backported to |
2 tasks
danbev added a commit
to danbev/node
that referenced
this pull request
Apr 30, 2018
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: nodejs#19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: nodejs#19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 6, 2018
This commit renames all JavaScript source files in lib to lower snake_case. Backport-PR-URL: #19969 PR-URL: #19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames all JavaScript source files in lib to lower snake_case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes