Skip to content

src: use unordered_map for perf marks - #19558

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:unordered
Closed

src: use unordered_map for perf marks#19558
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:unordered

Conversation

@addaleax

@addaleaxaddaleax commented Mar 23, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 23, 2018
@addaleaxaddaleax added lib / src Issues and PRs related to general changes in the lib or src directory. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 24, 2018
@addaleax

addaleax commented Mar 24, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/17151/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 27, 2018
@addaleax@BridgeAR
src: use unordered_map for perf marks
c46e36b
PR-URL: nodejs#19558
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

BridgeAR commented Mar 27, 2018

Copy link
Copy Markdown
Member

Landed in c46e36b 🎉

targos pushed a commit that referenced this pull request Mar 27, 2018
@addaleax@targos
src: use unordered_map for perf marks
780a5d6
PR-URL: #19558
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jun 29, 2018
@addaleax
src: use unordered_map for perf marks
9ef0887
PR-URL: #19558
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax@rvagg
src: use unordered_map for perf marks
d38ccbb
PR-URL: #19558
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.perf_hooksIssues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax@BridgeAR@jasnell@TimothyGu@cjihrig@trivikr@nodejs-github-bot