Skip to content

Revert "readline: allow tabs in input" - #1961

Closed
Fishrock123 wants to merge 1 commit into
nodejs:masterfrom
Fishrock123:revert-allow-tabs-inreadline-input
Closed

Revert "readline: allow tabs in input"#1961
Fishrock123 wants to merge 1 commit into
nodejs:masterfrom
Fishrock123:revert-allow-tabs-inreadline-input

Conversation

@Fishrock123

@Fishrock123Fishrock123 commented Jun 12, 2015

Copy link
Copy Markdown
Contributor

This reverts commit 4b3d493.

Result of some quick discussion with @Trott and @chrisdickinson at nodeconf, it appears this should be semver-major for safety.

cc @rvagg / @brendanashworth, this should land before 2.3.0 releases. (ASAP)

@Fishrock123Fishrock123 added the readline Issues and PRs related to the built-in readline module. label Jun 12, 2015
@Fishrock123Fishrock123 mentioned this pull request Jun 12, 2015
Closed
@Fishrock123

Fishrock123 commented Jun 12, 2015

Copy link
Copy Markdown
ContributorAuthor

Also, I will be landing this in next, assuming that LGT-Everyone.

@cjihrig

cjihrig commented Jun 12, 2015

Copy link
Copy Markdown
Contributor

LGTM

@yosuke-furukawa

yosuke-furukawa commented Jun 12, 2015

Copy link
Copy Markdown
Member

LGTM2

Fishrock123 added a commit that referenced this pull request Jun 12, 2015
@Fishrock123
Revert "readline: allow tabs in input"
d9e2502
This reverts commit 4b3d493.
PR-URL: #1961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
@Fishrock123

Fishrock123 commented Jun 12, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks, merged in d9e2502

@Fishrock123

Fishrock123 commented Jun 12, 2015

Copy link
Copy Markdown
ContributorAuthor

(Will land the original commit back into next momentarily.)

@Fishrock123Fishrock123 mentioned this pull request Jun 12, 2015
Closed
@Fishrock123

Fishrock123 commented Jun 12, 2015

Copy link
Copy Markdown
ContributorAuthor

Re-landed on next at 2ebc77d

@Trott

Trott commented Jun 20, 2015

Copy link
Copy Markdown
Member

@Fishrock123 Th re-landing of the change appears to have been clobbered at some point in next. Looking at https://github.com/nodejs/io.js/blob/next/lib/readline.js right now, all the code that was reverted on master in this change appears to be the same there as well. Am I looking at the wrong thing? If not, do you know what happened?

@rvaggrvagg mentioned this pull request Jul 30, 2015
Closed
Fishrock123 added a commit that referenced this pull request Aug 1, 2015
@Fishrock123@rvagg
Revert "readline: allow tabs in input"
83167ee
This reverts commit 4b3d493.
PR-URL: #1961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
This was referenced Jun 22, 2023
Open
Open
Open
Open
This was referenced Jul 7, 2023
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

readlineIssues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fishrock123@cjihrig@yosuke-furukawa@Trott