Uh oh!
There was an error while loading. Please reload this page.
[v6.x backport] src: free memory before re-setting URLHost value - #19639
Closed
prog1dev wants to merge 1 commit into
Closed
[v6.x backport] src: free memory before re-setting URLHost value#19639prog1dev wants to merge 1 commit into
prog1dev wants to merge 1 commit into
Conversation
TimothyGu
approved these changes
Mar 27, 2018
ContributorAuthor
Something went wrong 😄 |
TimothyGu
commented
Mar 29, 2018
Member
@prog1dev It’s probably because there have been force-pushes to the |
Fixes: nodejs#18302 PR-URL: nodejs#18357 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
prog1devforce-pushed
the
backport-18357-to-v6.x
branch
from
April 1, 2018 12:42
f067901 to
af2c41eCompareMylesBorins
commented
Apr 12, 2018
Contributor
MylesBorins pushed a commit
that referenced
this pull request
Apr 13, 2018
Fixes: #18302 Backport-PR-URL: #19639 PR-URL: #18357 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
commented
Apr 13, 2018
Contributor
landed in 0ca2dad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pr #18357
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes@MylesBorins