Uh oh!
There was an error while loading. Please reload this page.
test: rename regression tests with descriptive file names (pt. 7) - #19668
Closed
ryzokuken wants to merge 1 commit into
Closed
test: rename regression tests with descriptive file names (pt. 7)#19668ryzokuken wants to merge 1 commit into
ryzokuken wants to merge 1 commit into
Conversation
gireeshpunathil
approved these changes
Mar 29, 2018
lpinca
approved these changes
Mar 29, 2018
Member
jasnell
approved these changes
Mar 29, 2018
ryzokuken
commented
Mar 29, 2018
ContributorAuthor
@lpinca let me just add one more commit in a jiffy. |
lpinca
commented
Mar 29, 2018
Member
Sure. |
ryzokuken
commented
Mar 29, 2018
ContributorAuthor
@lpinca done, thanks! Please take a look at the new one, and if it looks good to you, I'll squash the two. |
lpinca
reviewed
Mar 29, 2018
Member
There was a problem hiding this comment.
Tiny nit: I'd simplify like "This test ensures that no asynchronous operations are performed in the 'exit' event handler".
Rename test-fs-truncate-nodejsGH-6233 to test-fs-truncate-clear-file-zero Rename test-process-exit-nodejsGH-12322 to test-process-exit-flaky-handler Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
lpinca
commented
Mar 29, 2018
Member
lpinca
commented
Apr 1, 2018
Member
Landed in 107b067. |
lpinca pushed a commit
that referenced
this pull request
Apr 1, 2018
- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 2, 2018
- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
2 tasks
BethGriggs pushed a commit
that referenced
this pull request
Dec 4, 2018
- Rename test-fs-truncate-GH-6233 to test-fs-truncate-clear-file-zero - Rename test-process-exit-GH-12322 to test-process-exit-handler PR-URL: #19668 Refs: #19105 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the tests appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the tests conform to the standard test structure
Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Checklist