Uh oh!
There was an error while loading. Please reload this page.
lint: change require-buffer rule message - #19701
Closed
devsnek wants to merge 2 commits into
Closed
Conversation
devsnek
commented
Mar 30, 2018
MemberAuthor
cjihrig
approved these changes
Mar 30, 2018
tniessen
approved these changes
Mar 30, 2018
lpinca
reviewed
Mar 30, 2018
| function flagIt(reference) { | ||
| const msg = 'Use const Buffer = require(\'buffer\').Buffer; ' + | ||
| 'at the beginning of this file'; | ||
| const msg = `Use ${BUFFER_REQUIRE} at the beginning of this file`; |
Member
There was a problem hiding this comment.
Nit: BUFFER_REQUIRE adds a new line, is this wanted?
MemberAuthor
There was a problem hiding this comment.
fantastic catch, thank you :)
lpinca
approved these changes
Mar 31, 2018
ChALkeR
approved these changes
Apr 1, 2018
ChALkeR
left a comment
Member
There was a problem hiding this comment.
LGTM, but this needs a CI-lite re-run prior to landing.
devsnek
commented
Apr 1, 2018
MemberAuthor
jasnell
approved these changes
Apr 1, 2018
devsnek
commented
Apr 3, 2018
MemberAuthor
landed in 5579118 |
devsnek added a commit
that referenced
this pull request
Apr 3, 2018
PR-URL: #19701 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 3, 2018
PR-URL: #19701 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes