Uh oh!
There was an error while loading. Please reload this page.
[v9.x backport] crypto: add ECDH.convertKey to convert public keys - #19745
Closed
targos wants to merge 2 commits into
Closed
[v9.x backport] crypto: add ECDH.convertKey to convert public keys#19745targos wants to merge 2 commits into
targos wants to merge 2 commits into
Conversation
targos
commented
Apr 2, 2018
MemberAuthor
Contributor
There was a problem hiding this comment.
Nit:
-- `format` {string} Defaults to `uncompressed`.+- `format` {string} **Default:** `uncompressed`As per #19737 (will be backported, but without this fix).
ECDH.convertKey is used to convert public keys between different formats. PR-URL: nodejs#19080Fixes: nodejs#18977 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
targosforce-pushed
the
backport-ecdh-convert-key
branch
from
April 4, 2018 13:07
73b22ed to
1b408f8Comparetargosforce-pushed
the
backport-ecdh-convert-key
branch
from
April 4, 2018 13:08
1b408f8 to
49573b7Comparetargos
commented
Apr 6, 2018
MemberAuthor
tniessen
approved these changes
Apr 6, 2018
targos
commented
Apr 12, 2018
MemberAuthor
Landed in f06b41e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECDH.convertKey is used to convert public keys between different
formats.
PR-URL: #19080
Fixes: #18977
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
/cc @tniessen