Uh oh!
There was an error while loading. Please reload this page.
dns: consistently add hostname - #19754
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
joyeecheung
approved these changes
Apr 2, 2018
Right now the hostname could in some cases be missed, depending on the libuv error number. This makes sure there the hostname is always added, if available.
BridgeAR
commented
Apr 5, 2018
MemberAuthor
jasnell
approved these changes
Apr 5, 2018
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Apr 5, 2018
Right now the hostname could in some cases be missed, depending on the libuv error number. This makes sure there the hostname is always added, if available. PR-URL: nodejs#19754 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
commented
Apr 5, 2018
MemberAuthor
Landed in b29c36b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the hostname could in some cases be missed, depending on
the libuv error number. This makes sure there the hostname is always
added, if available.
This currently relies on #19719 and I am
going to rebase the PR as soon as that lands.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes