Skip to content

test: tmpdir creation failures should fail tests - #1976

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:propagate-error
Closed

test: tmpdir creation failures should fail tests#1976
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:propagate-error

Conversation

@Trott

Copy link
Copy Markdown
Member

tmpdir creation only happens for tests that need it. So failure to
refresh the temporary directory should result in a failed test.

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/843/

/cc @rvagg who suggested it here and @Fishrock123 who suggested it here

@mscdexmscdex added the test Issues and PRs related to the tests. label Jun 14, 2015
@rvagg

Copy link
Copy Markdown
Member

yes yes, lgtm

@Trott

Copy link
Copy Markdown
MemberAuthor

Great! Unless someone else swoops in with an objection, I'll merge this Tuesday morning PDT (Tuesday afternoon UTC).

@Fishrock123

Copy link
Copy Markdown
Contributor

LGTM

@Trott

Copy link
Copy Markdown
MemberAuthor

Can somebody kick this off in Jenkins? (It's sitting in https://github.com/Trott/io.js master branch if you want to use that.) I appear to have lost my Job/Build permission and can't do it anymore. (/cc @rvagg)
screen shot 2015-06-16 at 8 11 15 am

@Trott

Copy link
Copy Markdown
MemberAuthor

Maybe @Fishrock123 or @chrisdickinson can kick off a CI run for me on this? I seem to have had my CI privs revoked or something...

@jbergstroem

Copy link
Copy Markdown
Member

CI here: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/26/

Not sure why you're getting permission issues. I'll have a look.

@jbergstroem

Copy link
Copy Markdown
Member

@Trott can you rebase on latest master?

Also, you're saying you are getting issues creating a job from this project? https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/

Trott added a commit to Trott/io.js that referenced this pull request Jun 17, 2015
tmpdir creation only happens for tests that need it. So failure to
refresh the temporary directory should result in a failed test.
PR-URL: nodejs#1976
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
tmpdir creation only happens for tests that need it. So failure to
refresh the temporary directory should result in a failed test.
@Trott

Copy link
Copy Markdown
MemberAuthor

Rebased as requested.

Yes, when I go to https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/, I no longer see "Build With Parameters" even though I'm logged in. And if I just go right to eh URL for building, I get the error in the screenshot above.

@jbergstroem

Copy link
Copy Markdown
Member

CI here: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/27/

I'm no Jenkins wizard, but we'll figure the permissions issue out somehow.

@Trott

Copy link
Copy Markdown
MemberAuthor

Merged in 88c1831

@TrottTrott closed this Jun 17, 2015
@rvagg

Copy link
Copy Markdown
Member

I suspect this is a case sensitivity issue with Jenkins, try again now @Trott I've added you back in to the permissions matrix lower-case

@Trott

Copy link
Copy Markdown
MemberAuthor

@rvagg My permissions are back, so that appears to have done it. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@rvagg@Fishrock123@jbergstroem@mscdex