Uh oh!
There was an error while loading. Please reload this page.
Make docs for console.time and console.timeEnd more complete - #198
Make docs for console.time and console.timeEnd more complete#198markstos wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Wrap to 80 colums, but otherwise looks much improved.
sam-github
commented
Dec 22, 2014
Looks good to me, the existing docs were pretty lacking, but can you squash the two commits and wrap to 80 columns? |
markstos
commented
Dec 23, 2014
This PR has been updated to squash previous commits and wrap at 80 lines as requested. |
bnoordhuis
commented
Dec 23, 2014
@markstos LGTM but can you make the commit log conform to what is outlined in CONTRIBUTING.md? Be as descriptive as possible in the first line; 'more complete' is too unspecific. Bonus points if you turn the references into links. It works like this: Where you pluck |
`console.time()` and `console.timeEnd()` are very closely related. It's useful to reference them both from each other. Previously, console.time() did not mention that it needed to be paired with a call to console.timeEnd() to be useful, and timeEnd() also failed to mention that console.time() needed to be called first. References in both directions have been added.
markstos
commented
Dec 23, 2014
Ben, I've reformatted the commit message as requested and added the links as On Tue, Dec 23, 2014 at 10:03 AM, Ben Noordhuis notifications@github.com
|
`console.time()` and `console.timeEnd()` are very closely related. It's useful to reference them both from each other. Previously, console.time() did not mention that it needed to be paired with a call to console.timeEnd() to be useful, and timeEnd() also failed to mention that console.time() needed to be called first. References in both directions have been added. PR-URL: #198 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
bnoordhuis
commented
Dec 23, 2014
Landed in 6af9483, thanks Mark! I reworded the first line to fit in 50 characters. |
nodejs-github-bot
commented
Feb 5, 2020
jasnell
commented
Feb 5, 2020
@nodejs/build ... any explanation why we're getting CI runs on old PRs? This is at least the second one I've seen today. |
richardlau
commented
Feb 5, 2020
@jasnell It's the CI's being started for the security releases and is kind of related to https://github.com/nodejs/github-bot/issues/245 (in that the build jobs are always passing |
jasnell
commented
Feb 5, 2020
Oy, that's not great. Ok, thanks for the explanation :) |
nodejs-github-bot
commented
Feb 5, 2020
* Update GetForegroundTaskRunner override * Fix line ending --------- Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
console.time()andconsole.timeEnd()are very closely related. It's useful to reference them both from each other.