Uh oh!
There was an error while loading. Please reload this page.
test: move test-http-client-timeout-agent to sequential - #19809
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Move resource-sensitive test from parallel to sequential. Fixes: nodejs#19804
Trott
commented
Apr 5, 2018
MemberAuthor
Trott
commented
Apr 5, 2018
MemberAuthor
Lone CI failure is unrelated. FreeBSD re-run: https://ci.nodejs.org/job/node-test-commit-freebsd/16732/ |
trivikr
approved these changes
Apr 5, 2018
lpinca
approved these changes
Apr 5, 2018
lpinca
commented
Apr 5, 2018
Member
I'd use "test: move test-http-client-timeout-agent" as commit title. |
jasnell
approved these changes
Apr 5, 2018
Trott added a commit
to Trott/io.js
that referenced
this pull request
Apr 7, 2018
Move resource-sensitive test from parallel to sequential. Fixes: nodejs#19804 PR-URL: nodejs#19809 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Apr 7, 2018
MemberAuthor
Landed in 95dc590 |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Move resource-sensitive test from parallel to sequential. Fixes: nodejs#19804 PR-URL: nodejs#19809 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move resource-sensitive test from parallel to sequential.
Fixes: #19804
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes