Skip to content

Revert 19560: npm 5.8.0 - #19837

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:revert-19560
Closed

Revert 19560: npm 5.8.0#19837
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:revert-19560

Conversation

@addaleax

@addaleaxaddaleax commented Apr 5, 2018

Copy link
Copy Markdown
Member

Breaks CI and local tests. These are clean reverts of the commits on top of master, so let’s land this ASAP.

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 5, 2018
@addaleaxaddaleax mentioned this pull request Apr 5, 2018
Closed
4 tasks
@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 5, 2018
@addaleax

addaleax commented Apr 5, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 026f6b7, e37effe + rewound v9.x-staging to its previous HEAD

@addaleaxaddaleax closed this Apr 5, 2018
@addaleax
addaleax deleted the revert-19560 branch April 5, 2018 21:00
addaleax added a commit that referenced this pull request Apr 5, 2018
@addaleax
Revert "deps: manually add 10.x support to npm"
026f6b7
This reverts commit 55557ba.
PR-URL: #19837
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Apr 5, 2018
@addaleax
Revert "deps: upgrade npm to 5.8.0"
e37effe
This reverts commit 25a816d.
PR-URL: #19837
Reviewed-By: Gus Caplan <me@gus.host>
@MylesBorins

MylesBorins commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

ugh... sorry about this... thought everything was working

@addaleax

addaleax commented Apr 5, 2018

Copy link
Copy Markdown
MemberAuthor

@MylesBorins Don’t worry, these things happen :)

@MylesBorins

MylesBorins commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

Oh I know... I break stuff all the time 🎉

Just like apologizing 😄

@SimenBSimenB mentioned this pull request Apr 30, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@MylesBorins@jasnell@devsnek@targos@nodejs-github-bot