Skip to content

doc: mention CCM along with GCM in crypto APIs - #19945

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-mention-ccm-with-gcm
Closed

doc: mention CCM along with GCM in crypto APIs#19945
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-mention-ccm-with-gcm

Conversation

@tniessen

@tniessentniessen commented Apr 11, 2018

Copy link
Copy Markdown
Member

Some API descriptions need to be updated after landing #18138.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 11, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2018
@BridgeAR

BridgeAR commented Apr 11, 2018

Copy link
Copy Markdown
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite/486/

@vsemozhetbyt

vsemozhetbyt commented Apr 11, 2018

Copy link
Copy Markdown
Contributor

New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/488/

@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2018
@tniessentniessen removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2018
@tniessen

tniessen commented Apr 13, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 04148b1.

tniessen added a commit that referenced this pull request Apr 13, 2018
@tniessen
doc: mention CCM along with GCM in crypto APIs
04148b1
PR-URL: #19945
Refs: #18138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@tniessen@jasnell
doc: mention CCM along with GCM in crypto APIs
0d1b77e
PR-URL: #19945
Refs: #18138
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@tniessentniessen removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@BridgeAR@vsemozhetbyt@jasnell@trivikr@nodejs-github-bot