Skip to content

doc: mention CI in Collaborator Guide - #1995

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:collab
Closed

doc: mention CI in Collaborator Guide#1995
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:collab

Conversation

@Trott

Copy link
Copy Markdown
Member

Add link to Jenkins server in Collaborator Guide.

Add link to Jenkins server in Collaborator Guide.
@mscdexmscdex added the doc Issues and PRs related to the documentations. label Jun 16, 2015
@TrottTrott changed the title doc: Collaborator Guide should mention CIdoc: mention CI in Collaborator GuideJun 16, 2015
@chrisdickinson

Copy link
Copy Markdown
Contributor

LGTM – and thanks for putting this together so quickly 👏

@Fishrock123

Copy link
Copy Markdown
Contributor

LGTM

@Trott

Copy link
Copy Markdown
MemberAuthor

Merged in c50ac2ed6b1bb0b6979d74ff6e832e986a0cd643

@TrottTrott closed this Jun 17, 2015
@Trott

Copy link
Copy Markdown
MemberAuthor

Uh...re-opening. Somehow this commit got clobbered. Did I do something wrong? Was a subsequent push a --force or something?

@TrottTrott reopened this Jun 18, 2015
Trott added a commit that referenced this pull request Jun 18, 2015
Add link to Jenkins server in Collaborator Guide.
PR-URL: #1995
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Merged in 0cf94e6

@TrottTrott closed this Jun 18, 2015
@rvaggrvagg mentioned this pull request Jun 18, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@chrisdickinson@Fishrock123@mscdex