Uh oh!
There was an error while loading. Please reload this page.
tools: treat SIGABRT as crash - #19990
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Otherwise, potentially no output is shown for aborts. Refs: nodejs#19903
gireeshpunathil
approved these changes
Apr 13, 2018
BridgeAR
approved these changes
Apr 13, 2018
cjihrig
approved these changes
Apr 13, 2018
joyeecheung
approved these changes
Apr 13, 2018
bnoordhuis
approved these changes
Apr 13, 2018
jasnell
approved these changes
Apr 13, 2018
refack
approved these changes
Apr 13, 2018
Member
Landed in dadddcb 🎉 |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 13, 2018
Otherwise, potentially no output is shown for aborts. PR-URL: nodejs#19990 Refs: nodejs#19903 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
commented
Apr 13, 2018
MemberAuthor
@BridgeAR Did this ever go through CI? I don’t think it’s causing issues, but it might be good to start a CI for |
jasnell pushed a commit
that referenced
this pull request
Apr 16, 2018
Otherwise, potentially no output is shown for aborts. PR-URL: #19990 Refs: #19903 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Otherwise, potentially no output is shown for aborts. PR-URL: nodejs#19990 Refs: nodejs#19903 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax added a commit
that referenced
this pull request
Jun 29, 2018
Otherwise, potentially no output is shown for aborts. PR-URL: #19990 Refs: #19903 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
rvagg pushed a commit
that referenced
this pull request
Aug 16, 2018
Otherwise, potentially no output is shown for aborts. PR-URL: #19990 Refs: #19903 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, potentially no output is shown for aborts.
Refs: #19903
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes