Skip to content

deps: bump V8 embedder string - #20105

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:bump-embedder-string
Closed

deps: bump V8 embedder string#20105
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:bump-embedder-string

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Apr 17, 2018

Copy link
Copy Markdown
Contributor

This was missed in a previous PR

Refs: #20016

would like this to fast track to not block other V8 prs

@MylesBorins
deps: bump V8 embedder string
87f83ef
This was missed in a previous PR
Refs: nodejs#20016
@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 17, 2018
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 17, 2018
@MylesBorinsMylesBorins mentioned this pull request Apr 17, 2018
Closed
3 tasks
@targos

targos commented Apr 17, 2018

Copy link
Copy Markdown
Member

+1 to fast track

@targostargos mentioned this pull request Apr 17, 2018
Closed
4 tasks
@jasnelljasnell added this to the 10.0.0 milestone Apr 17, 2018
richardlau
richardlau approved these changes Apr 17, 2018
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to fast track.

@MylesBorins

MylesBorins commented Apr 17, 2018 via email

Copy link
Copy Markdown
ContributorAuthor

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2018
@MylesBorins

MylesBorins commented Apr 17, 2018

Copy link
Copy Markdown
ContributorAuthor

landed in e86b319

MylesBorins added a commit that referenced this pull request Apr 17, 2018
@MylesBorins
deps: bump V8 embedder string
e86b319
This was missed in a previous PR
PR-URL: #20105
Refs: #20016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Apr 17, 2018
@MylesBorins@jasnell
deps: bump V8 embedder string
60eb95a
This was missed in a previous PR
PR-URL: #20105
Refs: #20016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@MylesBorins@targos@jasnell@richardlau@devsnek@BridgeAR@nodejs-github-bot