Skip to content

doc: fully document --experimental-repl-await - #20133

Closed
TimothyGu wants to merge 1 commit into
nodejs:masterfrom
TimothyGu:repl-doc
Closed

doc: fully document --experimental-repl-await#20133
TimothyGu wants to merge 1 commit into
nodejs:masterfrom
TimothyGu:repl-doc

Conversation

@TimothyGu

@TimothyGuTimothyGu commented Apr 18, 2018

Copy link
Copy Markdown
Member

Fixes: #19604 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 18, 2018
@vsemozhetbytvsemozhetbyt added the repl Issues and PRs related to the REPL subsystem. label Apr 18, 2018
@TimothyGuTimothyGu added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 18, 2018
@TimothyGu

Copy link
Copy Markdown
MemberAuthor

I'd like to fast track this. Please 👍-react if you agree!

@vsemozhetbyt

Copy link
Copy Markdown
Contributor

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 18, 2018
@vsemozhetbyt

Copy link
Copy Markdown
Contributor

This should be backported with #19604

@TimothyGu

Copy link
Copy Markdown
MemberAuthor

Landed in ceab78f.

TimothyGu added a commit that referenced this pull request Apr 18, 2018
PR-URL: #20133Fixes: #19604 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu
TimothyGu deleted the repl-doc branch April 18, 2018 21:13
jasnell pushed a commit that referenced this pull request Apr 19, 2018
PR-URL: #20133Fixes: #19604 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@TimothyGu@vsemozhetbyt@jasnell@richardlau@devsnek@ryzokuken@trivikr@nodejs-github-bot