Skip to content

src: create per-isolate strings after platform setup - #20175

Closed
ulan wants to merge 1 commit into
nodejs:masterfrom
ulan:per-isolate-strings
Closed

src: create per-isolate strings after platform setup#20175
ulan wants to merge 1 commit into
nodejs:masterfrom
ulan:per-isolate-strings

Conversation

@ulan

@ulanulan commented Apr 20, 2018

Copy link
Copy Markdown
Contributor

Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

Fixes: #20171

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 20, 2018
@addaleaxaddaleax added the v8 engine Issues and PRs related to the V8 dependency. label Apr 20, 2018
TimothyGu
TimothyGu approved these changes Apr 20, 2018
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commit message should be changed to conform to our convention though: "src: create strings after platform setup"

bnoordhuis
bnoordhuis approved these changes Apr 21, 2018
View reviewed changes
Comment threadsrc/env.cc Outdated

@bnoordhuisbnoordhuisApr 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not indent the preprocessor directives?

@ulanulanApr 23, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@BridgeARBridgeAR changed the title [src] create per-isolate strings after the platform is set up.src: create per-isolate strings after the platform is set upApr 23, 2018
@ulan
src: create per-isolate strings after platform setup
c2447f0
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.
Fixes: #20171
@ulanulan changed the title src: create per-isolate strings after the platform is set upsrc: create per-isolate strings after platform setupApr 23, 2018
@joyeecheung

joyeecheung commented Apr 23, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14445/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 26, 2018
@ulan@BridgeAR
src: create per-isolate strings after platform setup
8c12e01
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.
PR-URL: nodejs#20175Fixes: nodejs#20171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR

BridgeAR commented Apr 26, 2018

Copy link
Copy Markdown
Member

Landed in 8c12e01 🎉

@ulan

ulan commented Apr 26, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks for landing!

MylesBorins pushed a commit that referenced this pull request May 4, 2018
@ulan@MylesBorins
src: create per-isolate strings after platform setup
81de533
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.
PR-URL: #20175Fixes: #20171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
addaleax pushed a commit that referenced this pull request Jun 29, 2018
@ulan@addaleax
src: create per-isolate strings after platform setup
c06a41e
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.
PR-URL: #20175Fixes: #20171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@ulan@rvagg
src: create per-isolate strings after platform setup
e17f05a
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.
PR-URL: #20175Fixes: #20171
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+3 more reviewers
@danbevdanbevdanbev approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@hashseedhashseedhashseed approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node::IsolateData allocates V8 objects before initializing platform

11 participants

@ulan@joyeecheung@BridgeAR@bnoordhuis@danbev@jasnell@addaleax@TimothyGu@hashseed@cjihrig@nodejs-github-bot