lib: make sure console is writable

[kfarnung]

The code currently assumes that console is already writable, but
that's only if it was previously defined as writable. If it hasn't
already been defined then the default value is false.

Refs: #17708

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[kfarnung]

CI: https://ci.nodejs.org/job/node-test-pull-request/14411/

[devsnek]

@kfarnung this is because of a change in node-chakra right?

[addaleax]

Would be cool to have a test for this, if it's possible?

[cjihrig]

LGTM. +1 to adding a test.

[kfarnung]

@devsnek That's basically correct. At some point V8 moved their console object initialization out of the inspector code so they always initialize the console property as writable. In the case of node-chakracore we still only initialize the console object when inspector is included in the build. Since the intention is to have the property be always writable it seemed reasonable to just have this code ensure that the property is always writable.

@addaleax@cjihrig There are already existing tests for the behavior, but they fail in node-chakracore if we build without inspector (which is currently true for our WoA builds). See #17708 which added those tests. I'll add ref to that PR to this commit as well.

[kfarnung]

Rebased and kicked off a new CI: https://ci.nodejs.org/job/node-test-pull-request/14421/

[kfarnung]

The CI failures seem unrelated (there should be no functional change here):

https://ci.nodejs.org/job/node-test-commit-plinux/17100/nodes=ppcle-ubuntu1404/consoleText

match failed
line=6
expect=^oooooooooooooooooooooooooooooooooooooooooooooooo$
actual=oo����oooooooooooooooooooooooooooooooooooooooooo
not ok 2217 pseudo-tty/no_interleaved_stdio
---
duration_ms: 0.115
severity: fail
stack: |-
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oo����oooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
oooooooooooooooooooooooooooooooooooooooooooooooo
ooooooooooooooooooooooooO__This is some stderr__
...

https://ci.nodejs.org/job/node-test-commit-osx/18000/nodes=osx1010/consoleText

not ok 652 parallel/test-child-process-fork-net2
---
duration_ms: 120.429
severity: fail
exitcode: -15
stack: |-
timeout
...

[kfarnung]

New CI: https://ci.nodejs.org/job/node-test-pull-request/14463/

[kfarnung]

Looks like the macOS leg has some leftover processes:

# Clean up any leftover processes, error if found.
ps awwx | grep Release/node | grep -v grep | cat
67423 ?? R 32:31.66 /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/out/Release/node /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/parallel/test-listen-fd-detached-inherit.js parent
make[1]: *** [test-ci] Error 1
make: *** [run-ci] Error 2
Build step 'Execute shell' marked build as failure

Seems to be another instance of #20194.

[kfarnung]

Landed in 982adb5