doc,http2: add parameters for Http2Session:connect event

[ryzokuken]

Add parameters for the callback for the Http2Session:connect event
inline with the pattern in the rest of the documentation.

Refs: nodejs/help#877 (comment)

Checklist

• documentation is changed or added
• commit message follows commit guidelines

/cc @mcollina @nodejs/http2

[Trott]

We don't typically list parameters like that for events, do we? I think it's useful information to have, but I'm not sure that's the best way to list it. (Maybe it is. I honestly don't know.)

@nodejs/documentation

[apapirovski]

@Trott we do in the http and streams documentation. For example: https://nodejs.org/dist/latest-v9.x/docs/api/http.html#http_event_connect

[Trott]

@Trott we do in the http and streams documentation. For example: https://nodejs.org/dist/latest-v9.x/docs/api/http.html#http_event_connect

I never noticed that. OK, cool. If it's what we already do elsewhere, at least it's a unified approach.

[TimothyGu]

I don't think the "The associated ... instance" is that helpful since the same information is conveyed by the type annotation already. Otherwise, LGTM.

[TimothyGu]

You can just use {Http2Session} here.

[mcollina]

LGTM with @TimothyGu nit.

[ryzokuken]

@TimothyGu@mcollina is this better?

[vsemozhetbyt]

It's a bit unclear what this line means. If this is the first parameter of an event listener, we need to add a name to it, as the only unnamed types in docs are types of properties and returned values. If this is an event emitter, I do not think we formally state them in this way, as this is already inferred from the section place; this can baffle doctools.

[ryzokuken]

Umm, so should I add a name to it or skip it?

[vsemozhetbyt]

If this is not a listener parameter, but an event source, I think we can skip it as this event is already a subsection of Http2Session section.

[ryzokuken]

It's a parameter. Code:

process.nextTick(emit,this,'connect',this,socket);

[vsemozhetbyt]

So we need to add a name then for consistency if I am not mistaken. It seems we normally have not unnamed parameters in docs.

[ryzokuken]

naming it session, in that case.

[ryzokuken]

This is a single documentation change, and I believe it should be fast-forwarded. Please respond with 👍 to approve fast-forwarding this.

[vsemozhetbyt]

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/567/

[ryzokuken]

CI passed! 🎉
Landing it tonight.

[ryzokuken]

Squashing.

[ryzokuken]

Re-running CI Lite.

CI Lite: https://ci.nodejs.org/job/node-test-pull-request-lite/568/

[ryzokuken]

Passed again, landing.

[ryzokuken]

Landed in 31cbec7