Uh oh!
There was an error while loading. Please reload this page.
build: use -9 with kill in Makefile - #20195
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Apr 21, 2018
MemberAuthor
Trott
commented
Apr 21, 2018
MemberAuthor
Re-run Linux CI: https://ci.nodejs.org/job/node-test-commit-linux/18165/ |
TimothyGu
approved these changes
Apr 21, 2018
lpinca
approved these changes
Apr 21, 2018
addaleax
approved these changes
Apr 21, 2018
cjihrig
approved these changes
Apr 21, 2018
Trott
commented
Apr 21, 2018
MemberAuthor
Yet another Linux re-run: https://ci.nodejs.org/job/node-test-commit-linux/18173/ |
BridgeAR
approved these changes
Apr 21, 2018
4 tasks
Merged
Trott added a commit
to Trott/io.js
that referenced
this pull request
Apr 24, 2018
Fixes: nodejs#20194 PR-URL: nodejs#20195 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
commented
Apr 24, 2018
MemberAuthor
Landed in 7424d86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #20194
@nodejs/build
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes