Uh oh!
There was an error while loading. Please reload this page.
test: increase speed of test-benchmark-http - #20205
Closed
Trott wants to merge 1 commit into
Closed
Conversation
More benchmark options have been added but not specified in the benchmark test to reduce runtime of that test. This adds those options, reducing run time by about 40% on my machine locally.
Trott
commented
Apr 21, 2018
MemberAuthor
devsnek
approved these changes
Apr 21, 2018
cjihrig
approved these changes
Apr 21, 2018
Trott
commented
Apr 21, 2018
MemberAuthor
Ci is green. To approve fast-tracking, leave a 👍 on this comment. Thanks. |
apapirovski
commented
Apr 21, 2018
Contributor
Trott
commented
Apr 21, 2018
MemberAuthor
@apapirovski Cool. Hopefully that lands first and I just close this. But if it gets delayed because there are a bunch of other changes, I'll land this. I did this because the test timed out in CI. So I'd want to get this micro-fix in if that larger set of changes isn't going to happen soon. |
apapirovski
commented
Apr 22, 2018
Contributor
@Trott I've now landed my PR. I'll close this out — hope you don't mind. |
Trott
commented
Apr 23, 2018
MemberAuthor
Don't mind at all! Thanks for taking care of it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More benchmark options have been added but not specified in the
benchmark test to reduce runtime of that test. This adds those options,
reducing run time by about 40% on my machine locally.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes