Uh oh!
There was an error while loading. Please reload this page.
crypto: add getIntOption function to reduce dupl - #20247
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit adds a getIntOption function to reduce the code duplicated for getting the padding, and saltLength options.
danbev
commented
Apr 24, 2018
ContributorAuthor
addaleax
approved these changes
Apr 24, 2018
tniessen
approved these changes
Apr 24, 2018
cjihrig
approved these changes
Apr 24, 2018
trivikr
approved these changes
Apr 24, 2018
jasnell
approved these changes
Apr 24, 2018
lpinca
approved these changes
Apr 24, 2018
danbev
commented
Apr 26, 2018
ContributorAuthor
node-test-commit-osx failure looks unrelatedBuilding addon /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/addons-napi/1_hello_world/gyp info it worked if it ends with okgyp info using node-gyp@3.6.2gyp info using node@10.0.0-pre | darwin | x64gyp info chdir /Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/addons-napi/1_hello_world/gyp info spawn /usr/bin/pythongyp info spawn args [ '/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/deps/npm/node_modules/node-gyp/gyp/gyp_main.py',gyp info spawn args 'binding.gyp',gyp info spawn args '-f',gyp info spawn args 'make',gyp info spawn args '-I',gyp info spawn args '/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/addons-napi/1_hello_world/build/config.gypi',gyp info spawn args '-I',gyp info spawn args '/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/deps/npm/node_modules/node-gyp/addon.gypi',gyp info spawn args '-I',gyp info spawn args '/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/common.gypi',gyp info spawn args '-Dlibrary=shared_library',gyp info spawn args '-Dvisibility=default',gyp info spawn args '-Dnode_root_dir=/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010',gyp info spawn args '-Dnode_gyp_dir=/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/deps/npm/node_modules/node-gyp',gyp info spawn args '-Dnode_lib_file=/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/$(Configuration)/node.lib',gyp info spawn args '-Dmodule_root_dir=/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1010/test/addons-napi/1_hello_world',gyp info spawn args '-Dnode_engine=v8',gyp info spawn args '--depth=.',gyp info spawn args '--no-parallel',gyp info spawn args '--generator-output',gyp info spawn args 'build',gyp info spawn args '-Goutput_dir=.' ]xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instancexcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instancegyp info spawn makegyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 2 ] CC(target) Release/obj.target/binding/binding.o SOLINK_MODULE(target) Release/binding.nodegyp info ok |
danbev
commented
Apr 26, 2018
ContributorAuthor
Landed in d4726d2. |
danbev added a commit
that referenced
this pull request
Apr 26, 2018
This commit adds a getIntOption function to reduce the code duplicated for getting the padding, and saltLength options. PR-URL: #20247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
This commit adds a getIntOption function to reduce the code duplicated for getting the padding, and saltLength options. PR-URL: #20247 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a getIntOption function to reduce the code duplicated
for getting the padding, and saltLength options.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes