Uh oh!
There was an error while loading. Please reload this page.
doc: fix net.Socket link inconsistencies - #20271
Closed
Hackzzila wants to merge 2 commits into
Closed
Conversation
| --> | ||
| The `tty.WriteStream` class is a subclass of `net.Socket` that represents the | ||
| The `tty.WriteStream` class is a subclass of [`net.Socket`][] that represents the |
Contributor
There was a problem hiding this comment.
This line has 81 characters now which violates 80 characters limit and will cause doc linting issue. Can you rewrap?
vsemozhetbyt
approved these changes
Apr 25, 2018
vsemozhetbyt
commented
Apr 25, 2018
Contributor
Please, add 👍 here to approve fast-tracking. |
vsemozhetbyt
commented
Apr 25, 2018
Contributor
Trott
approved these changes
Apr 25, 2018
trivikr
approved these changes
Apr 25, 2018
lpinca
approved these changes
Apr 25, 2018
vsemozhetbyt
commented
Apr 25, 2018
Contributor
Landed in 214fd40 |
vsemozhetbyt pushed a commit
that referenced
this pull request
Apr 25, 2018
PR-URL: #20271 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20271 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a link to
net.Socketin the docs fortty.WriteStreamto be consistent withtty.ReadStreamChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes