Skip to content

doc: add emitter.off to events.md - #20291

Closed
Ajido wants to merge 2 commits into
nodejs:masterfrom
Ajido:master
Closed

doc: add emitter.off to events.md#20291
Ajido wants to merge 2 commits into
nodejs:masterfrom
Ajido:master

Conversation

@Ajido

@AjidoAjido commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

emitter.off is not listed in the current document. This patch adds that to the events.md.

Refs: #17156

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Apr 25, 2018
@tniessen

tniessen commented Apr 25, 2018

Copy link
Copy Markdown
Member

@nodejs/documentation

cjihrig
cjihrig approved these changes Apr 25, 2018
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to have removeListener() be a link, but it's up to you.

TimothyGu
TimothyGu approved these changes Apr 25, 2018
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to @cjihrig's comment.

@Ajido

Ajido commented Apr 25, 2018

Copy link
Copy Markdown
ContributorAuthor

@cjihrig Thank you for your advice.

@vsemozhetbytvsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018
@vsemozhetbyt

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Please, add 👍 here to approve fast-tracking.

@vsemozhetbyt

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/586/

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2018
vsemozhetbyt pushed a commit that referenced this pull request Apr 25, 2018
@Ajido@vsemozhetbyt
doc: add emitter.off() to events.md
1e40b75
PR-URL: #20291
Refs: #17156
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@vsemozhetbyt

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Landed in 1e40b75
Thank you, @Ajido!

MylesBorins pushed a commit that referenced this pull request May 4, 2018
@Ajido@MylesBorins
doc: add emitter.off() to events.md
c9b202f
PR-URL: #20291
Refs: #17156
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Ajido@tniessen@vsemozhetbyt@addaleax@TimothyGu@cjihrig@nodejs-github-bot