Skip to content

tools: remove redundant RegExp flag - #20309

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-re-flags
Closed

tools: remove redundant RegExp flag#20309
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-re-flags

Conversation

@vsemozhetbyt

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@vsemozhetbytvsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Apr 25, 2018
@vsemozhetbyt

Copy link
Copy Markdown
ContributorAuthor

@vsemozhetbyt

Copy link
Copy Markdown
ContributorAuthor

Please, add 👍 here to approve fast-tracking.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2018
@vsemozhetbyt

Copy link
Copy Markdown
ContributorAuthor

Landed in e2fa5a7

@vsemozhetbyt
vsemozhetbyt deleted the tools-re-flags branch April 28, 2018 02:10
vsemozhetbyt added a commit that referenced this pull request Apr 28, 2018
PR-URL: #20309
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
PR-URL: #20309
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@vsemozhetbyt@jasnell@cjihrig@BridgeAR@trivikr@nodejs-github-bot